[jira] [Commented] (MESOS-3136) COMMAND health checks with Marathon 0.10.0 are broken

["Erhan Kesken (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946378#comment-14946378 ] 

Erhan Kesken commented on MESOS-3136:
-------------------------------------

Issue is marked as resolved, but from line https://github.com/apache/mesos/blob/5058fac1083dc91bca54d33c26c810c17ad95dd1/src/docker/executor.cpp#L326 I understand that health check commands are executed in docker context now, but old behaviour was running at slave context.

As you can see at this thread https://groups.google.com/forum/#!topic/marathon-framework/S_k6k3ydQ-o , I believe many people currently have health check commands based on 'docker {exec,logs}' commands, including me.

even basic example at marathon docs https://mesosphere.github.io/marathon/docs/health-checks.html

{noformat}
{
  "protocol": "COMMAND",
  "command": { "value": "curl -f -X GET http://$HOST:$PORT0/health" },
  "gracePeriodSeconds": 300,
  "intervalSeconds": 60,
  "timeoutSeconds": 20,
  "maxConsecutiveFailures": 3
}
{noformat}

won't work, because you don't have curl package in your docker image most probably.

I think there should be a flag to get back old behaviour which was using slave context to execute health check commands to avoid people adding extra packages to their docker images and rewrite their health check commands.


> COMMAND health checks with Marathon 0.10.0 are broken
> -----------------------------------------------------
>
>                 Key: MESOS-3136
>                 URL: https://issues.apache.org/jira/browse/MESOS-3136
>             Project: Mesos
>          Issue Type: Bug
>    Affects Versions: 0.23.0
>            Reporter: Dr. Stefan Schimanski
>            Assignee: haosdent
>            Priority: Critical
>             Fix For: 0.23.1, 0.24.1, 0.25.0
>
>         Attachments: MESOS-3136_0_23_0.patch, MESOS-3136_0_24_0.patch
>
>
> When deploying Mesos 0.23rc4 with latest Marathon 0.10.0 RC3 command health check stop working. Rolling back to Mesos 0.22.1 fixes the problem.
> Containerizer is Docker.
> All packages are from official Mesosphere Ubuntu 14.04 sources.
> The issue must be analyzed further.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)