You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "arnaudbriche (via GitHub)" <gi...@apache.org> on 2025/04/04 14:04:42 UTC

[I] External CatalogIO implementation [iceberg-go]

arnaudbriche opened a new issue, #377:
URL: https://github.com/apache/iceberg-go/issues/377

   ### Feature Request / Improvement
   
   Hi,
   
   In my use case, where are using version-hint.text file as a catalog.
   I just had to implement CatalogIO on my own and it works OK.
   
   I think it's great that anyone can implement this interface to fit it's use-case.
   There is one issue though:
   
   ```
   CreateTable(
   	ctx context.Context,
   	identifier table.Identifier,
   	schema *iceberg.Schema,
   	opts ...catalog.CreateTableOpt,
   )
   ````
   
   Here the catalog.CreateTableOpt is an alias to an internal type. It makes it impossible to make use of opts when implementing an CatalogIO.
   
   Would you mind making this struct public ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] External CatalogIO implementation [iceberg-go]

Posted by "arnaudbriche (via GitHub)" <gi...@apache.org>.
arnaudbriche commented on issue #377:
URL: https://github.com/apache/iceberg-go/issues/377#issuecomment-2781493965

   Here it is: https://github.com/apache/iceberg-go/pull/380


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] External CatalogIO implementation [iceberg-go]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade closed issue #377: External CatalogIO implementation
URL: https://github.com/apache/iceberg-go/issues/377


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] External CatalogIO implementation [iceberg-go]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on issue #377:
URL: https://github.com/apache/iceberg-go/issues/377#issuecomment-2779453857

   Sure we can make the struct public, feel free to submit a PR for it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org