[GitHub] [incubator-heron] nwangtw commented on a change in pull request #3718: update heron-shell download handler logging

[GitBox <gi...@apache.org>]

nwangtw commented on a change in pull request #3718:
URL: https://github.com/apache/incubator-heron/pull/3718#discussion_r719858349



##########
File path: heron/shell/src/python/handlers/downloadhandler.py
##########
@@ -34,7 +35,14 @@ class DownloadHandler(tornado.web.RequestHandler):
   def get(self, path):
     """ get method """
 
-    logging.debug("request to download: %s", path)
+    handler = logging.StreamHandler()
+    handler.setFormatter(anticrlf.LogFormatter('%(levelname)s:%(name)s:%(message)s'))
+    logger = logging.getLogger(__name__)

Review comment:
       I am wondering if we should move this to a class variable so that no need to set the formatter every time. 
   
   Maybe not a big deal fro downloader though since downloading doesn't happen very often.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org