You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "CalvinKirs (via GitHub)" <gi...@apache.org> on 2026/10/09 07:37:49 UTC
[PR] [fix](fe) Fix HTTP system requests forwarded to the master [doris]
CalvinKirs opened a new pull request, #68823:
URL: https://github.com/apache/doris/pull/68823
### What problem does this PR solve?
An authorized `/rest/v1/system` request on a non-master FE forwards `SHOW PROC` with an HTTP context that has no negotiated MySQL capability. Reading that capability returns JSON business code 500. Skip MySQL protocol fields for this context while preserving forwarding for connections with an explicit capability.
### Release note
Fix `/rest/v1/system` on non-master FEs.
### Check List (For Author)
- Test: 21 targeted FE unit tests passed; Checkstyle passed. HTTP regression coverage added but not run locally (no cluster).
- Behavior changed: Yes, authorized HTTP system requests can be forwarded successfully.
- Does this need documentation: No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Fix HTTP system requests forwarded to the master [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68823:
URL: https://github.com/apache/doris/pull/68823#issuecomment-6078170568
<details>
<summary>TPC-H: <b>Total hot run time: 29268 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3d30c1f55bf9048dac7e49fc7f2a7bb14f2bf7b3, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17615 5670 5568 5568
q2 2141 305 266 266
q3 10230 1420 846 846
q4 4679 478 349 349
q5 7453 796 532 532
q6 191 191 160 160
q7 773 806 624 624
q8 9258 1321 1123 1123
q9 5724 4486 4469 4469
q10 6839 1298 1022 1022
q11 426 250 238 238
q12 638 400 282 282
q13 18048 3086 2398 2398
q14 286 275 242 242
q15 q16 737 728 677 677
q17 1220 745 571 571
q18 7119 6267 6198 6198
q19 1109 966 607 607
q20 404 336 227 227
q21 5444 2574 2624 2574
q22 424 366 295 295
Total cold run time: 100758 ms
Total hot run time: 29268 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 6743 6655 6834 6655
q2 748 603 564 564
q3 5553 5815 5288 5288
q4 2040 2182 1556 1556
q5 5699 5617 5871 5617
q6 255 189 145 145
q7 2231 2023 1797 1797
q8 3111 2805 2826 2805
q9 8207 8131 8052 8052
q10 3643 3631 3257 3257
q11 588 397 374 374
q12 669 706 505 505
q13 2740 3056 2394 2394
q14 289 296 274 274
q15 q16 660 699 609 609
q17 7806 6975 6836 6836
q18 13121 12300 13097 12300
q19 922 792 790 790
q20 2186 2170 1950 1950
q21 5815 4719 4782 4719
q22 493 460 414 414
Total cold run time: 73519 ms
Total hot run time: 66901 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Fix HTTP system requests forwarded to the master [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #68823:
URL: https://github.com/apache/doris/pull/68823#issuecomment-6092875488
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Fix HTTP system requests forwarded to the master [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68823:
URL: https://github.com/apache/doris/pull/68823#issuecomment-6078381671
<details>
<summary>ClickBench: <b>Total hot run time: 24.45 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3d30c1f55bf9048dac7e49fc7f2a7bb14f2bf7b3, data reload: false
query1 0.01 0.01 0.00
query2 0.10 0.05 0.05
query3 0.26 0.11 0.12
query4 1.62 0.12 0.12
query5 0.24 0.24 0.24
query6 1.17 0.69 0.70
query7 0.03 0.00 0.00
query8 0.05 0.04 0.04
query9 0.42 0.37 0.34
query10 0.60 0.60 0.58
query11 0.20 0.14 0.14
query12 0.19 0.14 0.14
query13 0.49 0.48 0.49
query14 0.98 0.96 0.96
query15 0.62 0.61 0.61
query16 0.34 0.33 0.32
query17 1.14 1.16 1.16
query18 0.23 0.20 0.20
query19 2.10 1.96 1.94
query20 0.02 0.02 0.01
query21 15.50 0.26 0.14
query22 4.50 0.06 0.05
query23 16.26 0.32 0.12
query24 3.13 0.61 0.44
query25 0.14 0.06 0.07
query26 1.41 0.24 0.16
query27 0.04 0.04 0.05
query28 2.29 0.63 0.41
query29 12.53 4.12 3.24
query30 0.28 0.14 0.13
query31 2.77 0.58 0.34
query32 3.21 0.61 0.53
query33 3.21 3.23 3.17
query34 15.59 4.00 3.39
query35 3.35 3.33 3.35
query36 0.55 0.46 0.43
query37 0.10 0.07 0.06
query38 0.05 0.04 0.04
query39 0.04 0.03 0.03
query40 0.17 0.14 0.13
query41 0.08 0.03 0.02
query42 0.04 0.03 0.03
query43 0.04 0.04 0.03
Total cold run time: 96.09 s
Total hot run time: 24.45 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Fix HTTP system requests forwarded to the master [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68823:
URL: https://github.com/apache/doris/pull/68823#issuecomment-6078311591
<details>
<summary>TPC-DS: <b>Total hot run time: 151580 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3d30c1f55bf9048dac7e49fc7f2a7bb14f2bf7b3, data reload: false
query5 4309 583 443 443
query6 429 203 213 203
query7 4799 447 218 218
query8 327 185 173 173
query9 8755 3908 3893 3893
query10 456 321 267 267
query11 5967 3422 3182 3182
query12 149 92 84 84
query13 1250 439 314 314
query14 6543 4780 4504 4504
query14_1 4268 4226 4198 4198
query15 210 197 176 176
query16 954 455 402 402
query17 887 656 555 555
query18 2417 429 302 302
query19 195 164 131 131
query20 80 83 85 83
query21 210 135 112 112
query22 13109 12945 12829 12829
query23 13113 12512 12011 12011
query23_1 12370 12401 12225 12225
query24 7070 817 475 475
query24_1 460 463 461 461
query25 540 424 366 366
query26 1321 263 140 140
query27 2756 440 266 266
query28 4618 1927 1921 1921
query29 1583 598 464 464
query30 296 224 182 182
query31 900 762 646 646
query32 154 92 93 92
query33 516 309 240 240
query34 917 851 494 494
query35 741 759 644 644
query36 804 809 754 754
query37 132 104 94 94
query38 1770 1764 1688 1688
query39 726 728 694 694
query39_1 687 664 697 664
query40 218 121 99 99
query41 71 68 67 67
query42 83 82 84 82
query43 370 374 322 322
query44 1290 707 693 693
query45 183 178 162 162
query46 827 960 568 568
query47 3075 3010 2925 2925
query48 294 298 214 214
query49 568 389 293 293
query50 673 267 208 208
query51 10548 10584 10493 10493
query52 75 80 67 67
query53 199 202 151 151
query54 254 193 180 180
query55 73 75 61 61
query56 241 202 198 198
query57 1588 1574 1598 1574
query58 276 250 240 240
query59 2346 2369 2109 2109
query60 295 235 222 222
query61 149 149 142 142
query62 402 337 286 286
query63 191 158 160 158
query64 2793 954 779 779
query65 3424 3378 3411 3378
query66 1783 418 293 293
query67 20194 20283 20057 20057
query68 3182 1004 599 599
query69 384 276 259 259
query70 911 840 817 817
query71 287 234 205 205
query72 2808 2600 2223 2223
query73 528 524 298 298
query74 4613 4450 4312 4312
query75 2331 2295 1899 1899
query76 2385 1015 606 606
query77 355 389 293 293
query78 9184 9006 8429 8429
query79 955 840 523 523
query80 728 455 333 333
query81 562 320 273 273
query82 581 135 107 107
query83 289 192 168 168
query84 317 119 122 119
query85 823 431 364 364
query86 343 239 228 228
query87 2002 1965 1801 1801
query88 3557 2669 2654 2654
query89 341 296 256 256
query90 1854 178 177 177
query91 155 157 120 120
query92 85 87 85 85
query93 977 1007 544 544
query94 489 300 285 285
query95 568 337 318 318
query96 654 524 229 229
query97 2454 2416 2318 2318
query98 156 144 145 144
query99 774 767 650 650
Total cold run time: 234636 ms
Total hot run time: 151580 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Fix HTTP system requests forwarded to the master [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #68823:
URL: https://github.com/apache/doris/pull/68823#issuecomment-6092917428
Codex automated review failed and did not complete.
Error: Review step was cancelled (possibly timeout or cancelled)
Workflow run: https://github.com/apache/doris/actions/runs/38017757260
Please inspect the workflow logs and rerun the review after the underlying issue is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Fix HTTP system requests forwarded to the master [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68823:
URL: https://github.com/apache/doris/pull/68823#issuecomment-6080744755
# FE Regression Coverage Report
Increment line coverage ` 0.00% (0/132)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/68823_3d30c1f55bf9048dac7e49fc7f2a7bb14f2bf7b3_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/68823_3d30c1f55bf9048dac7e49fc7f2a7bb14f2bf7b3_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Fix HTTP system requests forwarded to the master [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #68823:
URL: https://github.com/apache/doris/pull/68823#issuecomment-6092942247
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68823
commit: 3d30c1f55bf9048dac7e49fc7f2a7bb14f2bf7b3
base: cbfb86b3585728538f6139c7a2b235af69375eee
reviewed_at: 2026-10-10T10:45+08:00
reviewer: CalvinKirs
model: gpt-6-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 2, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- The multi-FE HTTP regression has not been run locally.
<sub>Reviewed locally with the `doris-repo-review` pipeline (a local port of `.github/workflows/code-review-runner.yml`). This is not a CI status check.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Fix HTTP system requests forwarded to the master [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #68823:
URL: https://github.com/apache/doris/pull/68823#issuecomment-6077767621
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Fix HTTP system requests forwarded to the master [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #68823:
URL: https://github.com/apache/doris/pull/68823#issuecomment-6078821097
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Fix HTTP system requests forwarded to the master [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68823:
URL: https://github.com/apache/doris/pull/68823#issuecomment-6076603888
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Fix HTTP system requests forwarded to the master [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #68823:
URL: https://github.com/apache/doris/pull/68823#issuecomment-6077827198
### Local `doris-repo-review` result — 2026-10-09
Reviewed commit: `3d30c1f55bf9048dac7e49fc7f2a7bb14f2bf7b3` (target: `master`). **Verdict: APPROVE** — 0 Blocker, 0 Major, 2 Minor. The review converged in one round and covered all three changed files.
- **Minor — follower coverage:** The [new `SHOW FRONTENDS` loop](https://github.com/apache/doris/blob/3d30c1f55bf9048dac7e49fc7f2a7bb14f2bf7b3/regression-test/suites/auth_p0/test_http_rest_v1_auth.groovy#L92-L95) can pass on a single-FE cluster without exercising the follower forwarding path. A dedicated two-FE test or an explicit follower assertion would close this gap.
- **Minor — grant replay:** After `GRANT admin`, [direct Basic-auth requests to every alive FE](https://github.com/apache/doris/blob/3d30c1f55bf9048dac7e49fc7f2a7bb14f2bf7b3/regression-test/suites/auth_p0/test_http_rest_v1_auth.groovy#L92-L99) may reach another follower before it replays the grant, causing an intermittent business-code 401 unrelated to this fix. Synchronize each target follower before its HTTP request.
The production forwarding path has no blocking finding: HTTP contexts omit the absent MySQL capability, the master restores its existing default, and real MySQL clients retain their negotiated flags. Before the final rebase, 21 targeted FE unit tests and Checkstyle passed. This read-only review did not rerun tests, and the multi-FE HTTP regression has not run locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Fix HTTP system requests forwarded to the master [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #68823:
URL: https://github.com/apache/doris/pull/68823#issuecomment-6077860907
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68823
commit: 3d30c1f55bf9048dac7e49fc7f2a7bb14f2bf7b3
base: cbfb86b3585728538f6139c7a2b235af69375eee
reviewed_at: 2026-10-09T17:05+08:00
reviewer: CalvinKirs
model: unavailable
effort: unknown
findings: {blocker: 0, major: 0, minor: 2, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- The multi-FE HTTP regression has not been run locally.
<sub>Reviewed locally with the `doris-repo-review` pipeline (a local port of `.github/workflows/code-review-runner.yml`). This is not a CI status check.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Fix HTTP system requests forwarded to the master [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68823:
URL: https://github.com/apache/doris/pull/68823#issuecomment-6080855444
# FE Regression Coverage Report
Increment line coverage ` 0.00% (0/132)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/68823_3d30c1f55bf9048dac7e49fc7f2a7bb14f2bf7b3_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/68823_3d30c1f55bf9048dac7e49fc7f2a7bb14f2bf7b3_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Fix HTTP system requests forwarded to the master [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs merged PR #68823:
URL: https://github.com/apache/doris/pull/68823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org