[jira] [Commented] (LOG4J2-2216) JMXFactoryConnector is not closed in ClientGui

["Remko Popma (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4J2-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336834#comment-16336834 ] 

Remko Popma commented on LOG4J2-2216:
-------------------------------------

Sounds reasonable. Will you be able to provide a patch or pull request for this? (It may be good to see if fixing this resolves the unclosed JMX threads issue you mentioned.)

You can check out the source from git (see http://logging.apache.org/log4j/2.x/build.html),
and build with {{mvn clean install -DskipTests}} (the tests take 20-30 minutes to run).


> JMXFactoryConnector is not closed in ClientGui
> ----------------------------------------------
>
>                 Key: LOG4J2-2216
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2216
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: JMX
>    Affects Versions: 2.6, 2.8
>            Reporter: edgar wang
>            Priority: Minor
>
> JMXFactoryConnector is not closed in ClientGui. This potentially could cause a thread leak according to [https://stackoverflow.com/questions/564589/dynamic-proxies-with-jmx-can-cause-thread-leaks] . Since JMXFactoryConnector implements closable and autoclosable, it should be wrapped in a try with resources or the connector should be closed somewhere.
> We've seen several unclosed JMX threads in our production environment and believe this could be a reason why. 
> Could anyone advise?
> Thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)