You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Knut Anders Hatlen (JIRA)" <ji...@apache.org> on 2012/06/23 13:42:42 UTC
[jira] [Created] (DERBY-5830) Make DoubleProperties.propertyNames()
thread-safe
Knut Anders Hatlen created DERBY-5830:
-----------------------------------------
Summary: Make DoubleProperties.propertyNames() thread-safe
Key: DERBY-5830
URL: https://issues.apache.org/jira/browse/DERBY-5830
Project: Derby
Issue Type: Bug
Components: Services
Affects Versions: 10.9.1.0
Reporter: Knut Anders Hatlen
Assignee: Knut Anders Hatlen
As discussed in DERBY-4269, DoubleProperties.propertyNames() may throw a NullPointerException if properties are removed by another thread while the method is executing. Since DoubleProperties is a sub-class of, and used as a drop-in replacement for, java.util.Properties, it should be thread-safe just like the propertyNames() method in the parent class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5830) Make DoubleProperties.propertyNames()
thread-safe
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-5830:
--------------------------------------
Attachment: keys-only-v2.diff
Attaching keys-only-v2.diff, based on keys-only.diff attached to DERBY-4269. The patch removes the unnecessary calls to Properties.getProperty(). Unlike the original keys-only.diff, it uses a HashSet to store the set of property names so that duplicate names are removed automatically.
Both suites.All and derbyall ran cleanly with the patch.
> Make DoubleProperties.propertyNames() thread-safe
> -------------------------------------------------
>
> Key: DERBY-5830
> URL: https://issues.apache.org/jira/browse/DERBY-5830
> Project: Derby
> Issue Type: Bug
> Components: Services
> Affects Versions: 10.9.1.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Attachments: keys-only-v2.diff
>
>
> As discussed in DERBY-4269, DoubleProperties.propertyNames() may throw a NullPointerException if properties are removed by another thread while the method is executing. Since DoubleProperties is a sub-class of, and used as a drop-in replacement for, java.util.Properties, it should be thread-safe just like the propertyNames() method in the parent class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5830) Make DoubleProperties.propertyNames()
thread-safe
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-5830:
--------------------------------------
Issue & fix info: Patch Available
> Make DoubleProperties.propertyNames() thread-safe
> -------------------------------------------------
>
> Key: DERBY-5830
> URL: https://issues.apache.org/jira/browse/DERBY-5830
> Project: Derby
> Issue Type: Bug
> Components: Services
> Affects Versions: 10.9.1.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Attachments: keys-only-v2.diff
>
>
> As discussed in DERBY-4269, DoubleProperties.propertyNames() may throw a NullPointerException if properties are removed by another thread while the method is executing. Since DoubleProperties is a sub-class of, and used as a drop-in replacement for, java.util.Properties, it should be thread-safe just like the propertyNames() method in the parent class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (DERBY-5830) Make DoubleProperties.propertyNames()
thread-safe
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen closed DERBY-5830.
-------------------------------------
Resolution: Fixed
Fix Version/s: 10.10.0.0
10.9.1.1
10.8.2.3
Issue & fix info: (was: Patch Available)
Backported to 10.9 (revision 1359064) and 10.8 (revision 1359065). Closing the issue.
> Make DoubleProperties.propertyNames() thread-safe
> -------------------------------------------------
>
> Key: DERBY-5830
> URL: https://issues.apache.org/jira/browse/DERBY-5830
> Project: Derby
> Issue Type: Bug
> Components: Services
> Affects Versions: 10.9.1.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Fix For: 10.8.2.3, 10.9.1.1, 10.10.0.0
>
> Attachments: keys-only-v2.diff
>
>
> As discussed in DERBY-4269, DoubleProperties.propertyNames() may throw a NullPointerException if properties are removed by another thread while the method is executing. Since DoubleProperties is a sub-class of, and used as a drop-in replacement for, java.util.Properties, it should be thread-safe just like the propertyNames() method in the parent class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5830) Make
DoubleProperties.propertyNames() thread-safe
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400472#comment-13400472 ]
Dag H. Wanvik commented on DERBY-5830:
--------------------------------------
Looks like a good improvement in its own right. +1
> Make DoubleProperties.propertyNames() thread-safe
> -------------------------------------------------
>
> Key: DERBY-5830
> URL: https://issues.apache.org/jira/browse/DERBY-5830
> Project: Derby
> Issue Type: Bug
> Components: Services
> Affects Versions: 10.9.1.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Attachments: keys-only-v2.diff
>
>
> As discussed in DERBY-4269, DoubleProperties.propertyNames() may throw a NullPointerException if properties are removed by another thread while the method is executing. Since DoubleProperties is a sub-class of, and used as a drop-in replacement for, java.util.Properties, it should be thread-safe just like the propertyNames() method in the parent class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5830) Make
DoubleProperties.propertyNames() thread-safe
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401234#comment-13401234 ]
Knut Anders Hatlen commented on DERBY-5830:
-------------------------------------------
Thanks, Dag. Committed revision 1353852.
I'm also planning to backport this fix to 10.9, and possibly 10.8.
> Make DoubleProperties.propertyNames() thread-safe
> -------------------------------------------------
>
> Key: DERBY-5830
> URL: https://issues.apache.org/jira/browse/DERBY-5830
> Project: Derby
> Issue Type: Bug
> Components: Services
> Affects Versions: 10.9.1.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Attachments: keys-only-v2.diff
>
>
> As discussed in DERBY-4269, DoubleProperties.propertyNames() may throw a NullPointerException if properties are removed by another thread while the method is executing. Since DoubleProperties is a sub-class of, and used as a drop-in replacement for, java.util.Properties, it should be thread-safe just like the propertyNames() method in the parent class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira