You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rayees Namathponnan <ra...@citrix.com> on 2014/04/16 00:23:31 UTC
Review Request 20389: CLOUDSTACK-6416: fixed postinstall.sh script to fetch
cloudstack snapshot from appropriate branch.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20389/
-----------------------------------------------------------
Review request for cloudstack, Animesh Chaturvedi, Frank Zhang, and Nitin Mehta.
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6416: fixed postinstall.sh script to fetch cloudstack snapshot from appropriate branch.
Diffs
-----
tools/appliance/definitions/systemvmtemplate/postinstall.sh 997d854
Diff: https://reviews.apache.org/r/20389/diff/
Testing
-------
Yes
Thanks,
Rayees Namathponnan
Re: Review Request 20389: CLOUDSTACK-6416: fixed postinstall.sh script to
fetch cloudstack snapshot from appropriate branch.
Posted by Rayees Namathponnan <ra...@citrix.com>.
> On April 15, 2014, 10:54 p.m., Prachi Damle wrote:
> > Looks like the code change to get the snapshot from the correct branch - 4.2 in this case, looks ok. This changes is to be applied on 4.2 only.
Yes, this required only in 4.2
64-bit template script already updated in below check-in https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=d6d5ca0ef7dc10d25d8c6c5312232caf06895d47
- Rayees
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20389/#review40468
-----------------------------------------------------------
On April 15, 2014, 11:02 p.m., Rayees Namathponnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20389/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 11:02 p.m.)
>
>
> Review request for cloudstack, Animesh Chaturvedi, Frank Zhang, and Prachi Damle.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6416: fixed postinstall.sh script to fetch cloudstack snapshot from appropriate branch.
>
>
> Diffs
> -----
>
> tools/appliance/definitions/systemvmtemplate/postinstall.sh 997d854
>
> Diff: https://reviews.apache.org/r/20389/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Rayees Namathponnan
>
>
Re: Review Request 20389: CLOUDSTACK-6416: fixed postinstall.sh script to
fetch cloudstack snapshot from appropriate branch.
Posted by Prachi Damle <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20389/#review40468
-----------------------------------------------------------
Ship it!
Looks like the code change to get the snapshot from the correct branch - 4.2 in this case, looks ok. This changes is to be applied on 4.2 only.
- Prachi Damle
On April 15, 2014, 10:23 p.m., Rayees Namathponnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20389/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 10:23 p.m.)
>
>
> Review request for cloudstack, Animesh Chaturvedi, Frank Zhang, and Nitin Mehta.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6416: fixed postinstall.sh script to fetch cloudstack snapshot from appropriate branch.
>
>
> Diffs
> -----
>
> tools/appliance/definitions/systemvmtemplate/postinstall.sh 997d854
>
> Diff: https://reviews.apache.org/r/20389/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Rayees Namathponnan
>
>
Re: Review Request 20389: CLOUDSTACK-6416: fixed postinstall.sh script to
fetch cloudstack snapshot from appropriate branch.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20389/#review40480
-----------------------------------------------------------
Commit 0610dbf803d1b1dc37b41b3a6319cfcd94cf6bbe in cloudstack's branch refs/heads/4.2 from rayeesn
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0610dbf ]
Fixed provided for CLOUDSTACK-6416 need to be ported for 32 bit template also
- ASF Subversion and Git Services
On April 15, 2014, 11:02 p.m., Rayees Namathponnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20389/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 11:02 p.m.)
>
>
> Review request for cloudstack, Animesh Chaturvedi, Frank Zhang, and Prachi Damle.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6416: fixed postinstall.sh script to fetch cloudstack snapshot from appropriate branch.
>
>
> Diffs
> -----
>
> tools/appliance/definitions/systemvmtemplate/postinstall.sh 997d854
>
> Diff: https://reviews.apache.org/r/20389/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Rayees Namathponnan
>
>
Re: Review Request 20389: CLOUDSTACK-6416: fixed postinstall.sh script to
fetch cloudstack snapshot from appropriate branch.
Posted by Rayees Namathponnan <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20389/
-----------------------------------------------------------
(Updated April 15, 2014, 11:02 p.m.)
Review request for cloudstack, Animesh Chaturvedi, Frank Zhang, and Prachi Damle.
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6416: fixed postinstall.sh script to fetch cloudstack snapshot from appropriate branch.
Diffs
-----
tools/appliance/definitions/systemvmtemplate/postinstall.sh 997d854
Diff: https://reviews.apache.org/r/20389/diff/
Testing
-------
Yes
Thanks,
Rayees Namathponnan