geode git commit: addressing review comments

[bs...@apache.org]

Repository: geode
Updated Branches:
  refs/heads/feature/GEODE-3447 7d6a0a3e3 -> 404eeca8d


addressing review comments


Project: http://git-wip-us.apache.org/repos/asf/geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/404eeca8
Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/404eeca8
Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/404eeca8

Branch: refs/heads/feature/GEODE-3447
Commit: 404eeca8d6181a016ba520676bc79da6c90173c9
Parents: 7d6a0a3
Author: Bruce Schuchardt <bs...@pivotal.io>
Authored: Tue Aug 22 14:34:36 2017 -0700
Committer: Bruce Schuchardt <bs...@pivotal.io>
Committed: Tue Aug 22 14:34:36 2017 -0700

----------------------------------------------------------------------
 .../apache/geode/security/StreamAuthorizer.java    | 17 ++++++++++++++---
 .../protobuf/ProtobufSimpleAuthenticator.java      |  1 +
 2 files changed, 15 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/geode/blob/404eeca8/geode-core/src/main/java/org/apache/geode/security/StreamAuthorizer.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/security/StreamAuthorizer.java b/geode-core/src/main/java/org/apache/geode/security/StreamAuthorizer.java
index c6cef33..fdb6b17 100644
--- a/geode-core/src/main/java/org/apache/geode/security/StreamAuthorizer.java
+++ b/geode-core/src/main/java/org/apache/geode/security/StreamAuthorizer.java
@@ -1,8 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
 package org.apache.geode.security;
 
-/**
- * Created by bschuchardt on 8/17/17.
- */
 public interface StreamAuthorizer {
   boolean authorize(ResourcePermission permissionRequested);
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/404eeca8/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthenticator.java
----------------------------------------------------------------------
diff --git a/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthenticator.java b/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthenticator.java
index 98981f9..a7cc987 100644
--- a/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthenticator.java
+++ b/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthenticator.java
@@ -58,6 +58,7 @@ public class ProtobufSimpleAuthenticator implements StreamAuthenticator {
 
   @Override
   public boolean isAuthenticated() {
+    // note: an authorizer is only created if the user has been authenticated
     return authorizer != null;
   }