[GitHub] [activemq-artemis] clebertsuconic commented on issue #2746: ARTEMIS-2412: Allow CF configuration through JNDI references

[GitBox <gi...@apache.org>]

clebertsuconic commented on issue #2746: ARTEMIS-2412: Allow CF configuration through JNDI references
URL: https://github.com/apache/activemq-artemis/pull/2746#issuecomment-512000011
 
 
   I'm sorry, but I can't merge this with a merge commit on your branch.
   
   
   Your add test is a merge commit.
   
   
   Please, keep your branch flat. it's impossible to work with merge commits on any PR on any project I know out there.
   
   
   do the following at least:
   
   
   ```
   git pull --rebase upstream master
   git push origin -f <your-branch-name>
   ```
   
   
   Other things missing:
   
   a JIRA: and a JIRA comment on your commit
   
   
   you should have a single commit on your PR.
   
   
   Let me know if you need any help with git-fu on cleaning up your PR. I'm usually good on cleaning up myself with intermediate branches, but your case here was a bit difficult for me. It should be easier on your end since you know your changes.
   
   
   thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services