You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/11/17 21:32:01 UTC

[GitHub] [kafka] jsancio opened a new pull request #11511: MINOR: Brokers in KRaft don't need controller listener

jsancio opened a new pull request #11511:
URL: https://github.com/apache/kafka/pull/11511


   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji commented on a change in pull request #11511: MINOR: Brokers in KRaft don't need controller listener

Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #11511:
URL: https://github.com/apache/kafka/pull/11511#discussion_r751809367



##########
File path: core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala
##########
@@ -84,14 +84,6 @@ abstract class IntegrationTestHarness extends KafkaServerTestHarness {
   private def insertControllerListenersIfNeeded(props: Seq[Properties]): Unit = {
     if (isKRaftTest()) {
       props.foreach { config =>
-        // Add the CONTROLLER listener to "listeners" if it is not already there.

Review comment:
       Do we still need this method if we are no longer inserting controller listeners? Maybe we could rename it if the security config below is still needed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jsancio commented on a change in pull request #11511: MINOR: Brokers in KRaft don't need controller listener

Posted by GitBox <gi...@apache.org>.
jsancio commented on a change in pull request #11511:
URL: https://github.com/apache/kafka/pull/11511#discussion_r751861309



##########
File path: core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala
##########
@@ -84,14 +84,6 @@ abstract class IntegrationTestHarness extends KafkaServerTestHarness {
   private def insertControllerListenersIfNeeded(props: Seq[Properties]): Unit = {
     if (isKRaftTest()) {
       props.foreach { config =>
-        // Add the CONTROLLER listener to "listeners" if it is not already there.

Review comment:
       You are right. I removed this method. `QuorumTestHarness` only really supports `PLAINTEXT` for the controller listener. I think we are going to need additional changes to `QuorumTestHarness` to support some of the other security protocols. We can do that when we migrate an integration test that needs this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji merged pull request #11511: MINOR: Brokers in KRaft don't need controller listener

Posted by GitBox <gi...@apache.org>.
hachikuji merged pull request #11511:
URL: https://github.com/apache/kafka/pull/11511


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] rondagostino commented on pull request #11511: MINOR: Brokers in KRaft don't need controller listener

Posted by GitBox <gi...@apache.org>.
rondagostino commented on pull request #11511:
URL: https://github.com/apache/kafka/pull/11511#issuecomment-972074621


   Yeah, makes sense.  Much discussion about this occurred in https://github.com/apache/kafka/pull/11503/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jsancio commented on a change in pull request #11511: MINOR: Brokers in KRaft don't need controller listener

Posted by GitBox <gi...@apache.org>.
jsancio commented on a change in pull request #11511:
URL: https://github.com/apache/kafka/pull/11511#discussion_r751861309



##########
File path: core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala
##########
@@ -84,14 +84,6 @@ abstract class IntegrationTestHarness extends KafkaServerTestHarness {
   private def insertControllerListenersIfNeeded(props: Seq[Properties]): Unit = {
     if (isKRaftTest()) {
       props.foreach { config =>
-        // Add the CONTROLLER listener to "listeners" if it is not already there.

Review comment:
       You are right. I removed this method. `QuorumTestHarness` only really supports `PLAINTEXT` for the controller listener. I think we are going to need additional changes to `QuorumTestHarness` to support some of the other security protocols.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jsancio commented on pull request #11511: MINOR: Brokers in KRaft don't need controller listener

Posted by GitBox <gi...@apache.org>.
jsancio commented on pull request #11511:
URL: https://github.com/apache/kafka/pull/11511#issuecomment-973737297


   @hachikuji I updated the description.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org