You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/06/13 14:31:17 UTC
[PR] Align plugin workflows with structured planning contracts [shardingsphere]
terrymanu opened a new pull request, #38849:
URL: https://github.com/apache/shardingsphere/pull/38849
- validate prompt placeholders while preserving resource URI templates
- add plan/apply navigation and rendered continuation context for MCP plugins
- provide algorithm recommendations and property requirements for readwrite, shadow, and sharding workflows
- decompose sharding planning requests, services, and resource handlers with focused tests
- update Speckit tasks and MCP workflow documentation
For #35294.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Align plugin workflows with structured planning contracts [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #38849:
URL: https://github.com/apache/shardingsphere/pull/38849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Align plugin workflows with structured planning contracts [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #38849:
URL: https://github.com/apache/shardingsphere/pull/38849#issuecomment-4701258945
## Summary
Merge Decision: Mergeable
I did not find blocking issues in the latest PR head. The changes stay within the MCP plugin workflow scope, add focused coverage for the new descriptor/planning contracts, and pass the relevant local format/style/test gates.
## Review Details
Reviewed latest head `9ec0e16f52d` against base `0c09754f7853`. The GitHub file list matches the local diff boundary: 108 changed files.
The PR is consistent with the linked #35294 MCP workflow direction: descriptor validation now preserves resource URI templates while rejecting unsupported model-facing placeholders, readwrite/shadow/sharding workflows add algorithm recommendation and required-property clarification before artifact generation, and sharding planning/resource handling is split into focused services and handlers without crossing into parser, runtime SQL execution, dependency, distribution, or native-image areas.
Test coverage is adequate for this slice. The new/updated tests cover descriptor placeholder validation, client-form-only prompt arguments, readwrite load-balance property requirements, shadow algorithm recommendation and cleanup safety, sharding algorithm/key-generator requirements, missing-input/error paths, resource handler navigation payloads, provider registration, and the split planning service wrappers.
Release notes do not appear required for this split PR: the change is part of an ongoing MCP workflow documentation/plugin alignment sequence, and the PR updates the relevant user-facing MCP docs directly.
## Local Verification
- `./mvnw spotless:check -Pcheck -T1C` passed.
- `./mvnw -pl mcp/support,mcp/features/broadcast,mcp/features/readwrite-splitting,mcp/features/shadow,mcp/features/sharding -am checkstyle:check -Pcheck -T1C` passed.
- `./mvnw -pl mcp/support,mcp/features/broadcast,mcp/features/readwrite-splitting,mcp/features/shadow,mcp/features/sharding -am -DskipITs -Dspotless.skip=true -Dsurefire.failIfNoSpecifiedTests=false test` passed.
No change requests from my side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org