You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/11/04 11:35:56 UTC

[GitHub] [rocketmq-client-go] ingtube-zhangkun opened a new pull request #551: fix: sendMessageBack fail

ingtube-zhangkun opened a new pull request #551:
URL: https://github.com/apache/rocketmq-client-go/pull/551


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] codecov-io commented on pull request #551: fix: sendMessageBack fail

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #551:
URL: https://github.com/apache/rocketmq-client-go/pull/551#issuecomment-721682845


   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/551?src=pr&el=h1) Report
   > Merging [#551](https://codecov.io/gh/apache/rocketmq-client-go/pull/551?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/e1d9be806c182c142aee212eab27e413705f4e79?el=desc) will **not change** coverage.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/551/graphs/tree.svg?width=650&height=150&src=pr&token=CiV9ofPkG3)](https://codecov.io/gh/apache/rocketmq-client-go/pull/551?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #551   +/-   ##
   =======================================
     Coverage   24.21%   24.21%           
   =======================================
     Files          48       48           
     Lines        5010     5010           
   =======================================
     Hits         1213     1213           
     Misses       3598     3598           
     Partials      199      199           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/551?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/551/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `11.34% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/551?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/551?src=pr&el=footer). Last update [e1d9be8...79b41f5](https://codecov.io/gh/apache/rocketmq-client-go/pull/551?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] ingtube-zhangkun commented on pull request #551: fix: sendMessageBack fail

Posted by GitBox <gi...@apache.org>.
ingtube-zhangkun commented on pull request #551:
URL: https://github.com/apache/rocketmq-client-go/pull/551#issuecomment-737030721


   当达到最大消费次数 入死信队列的时候,选择的broker为msg.StoreHost  而StoreHost可能是不可达的  不需要处理吗?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] codecov-io edited a comment on pull request #551: fix: sendMessageBack fail

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #551:
URL: https://github.com/apache/rocketmq-client-go/pull/551#issuecomment-721682845


   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/551?src=pr&el=h1) Report
   > Merging [#551](https://codecov.io/gh/apache/rocketmq-client-go/pull/551?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/e1d9be806c182c142aee212eab27e413705f4e79?el=desc) will **not change** coverage.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/551/graphs/tree.svg?width=650&height=150&src=pr&token=CiV9ofPkG3)](https://codecov.io/gh/apache/rocketmq-client-go/pull/551?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #551   +/-   ##
   =======================================
     Coverage   24.21%   24.21%           
   =======================================
     Files          48       48           
     Lines        5010     5010           
   =======================================
     Hits         1213     1213           
     Misses       3598     3598           
     Partials      199      199           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/551?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/551/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `11.34% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/551?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/551?src=pr&el=footer). Last update [e1d9be8...79b41f5](https://codecov.io/gh/apache/rocketmq-client-go/pull/551?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] ingtube-zhangkun closed pull request #551: fix: sendMessageBack fail

Posted by GitBox <gi...@apache.org>.
ingtube-zhangkun closed pull request #551:
URL: https://github.com/apache/rocketmq-client-go/pull/551


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org