[GitHub] [couchdb-b64url] nickva commented on a change in pull request #9: Format code with erlfmt, run dialyzer in CI

[GitBox <gi...@apache.org>]

nickva commented on a change in pull request #9:
URL: https://github.com/apache/couchdb-b64url/pull/9#discussion_r751911334



##########
File path: .github/workflows/ci.yml
##########
@@ -16,30 +16,52 @@ jobs:
         otp-version: ['22', '23', '24']
         # erlef/setup-beam action does not support macos yet
         os: [ubuntu-latest, windows-latest]
+        rebar3-version: ['3.17']
+        include:
+          - otp-version: '21'
+            os: ubuntu-latest
+            rebar3-version: '3.15.2'
+          - otp-version: '21'
+            os: windows-latest
+            rebar3-version: '3.15.2'
+          - otp-version: '20'
+            os: ubuntu-latest
+            rebar3-version: '3.15.2'
+
     runs-on: ${{ matrix.os }}
     env:
-      # Set to 1 for verbose rebar3 logging
-      DEBUG: 0
-      # Set to 1 for even more verbose rebar3 logging
-      DIAGNOSTIC: 0
+      # Define to something other than empty string to enable verbose rebar3 logging
+      DEBUG: ''
     steps:
       - name: Check out repository code
         uses: actions/checkout@v2
         with:
           persist-credentials: false
           submodules: recursive
       - name: Setup Erlang
+        id: setup-beam
         uses: ./.github/actions/setup-beam
         with:
           otp-version: ${{ matrix.otp-version }}
-          rebar3-version: '3.17'
+          rebar3-version: ${{ matrix.rebar3-version }}
       - name: Setup MSVC toolchain
         if: ${{ matrix.os == 'windows-latest' }}
         uses: ./.github/actions/msvc-dev-cmd
+      - name: Check coding style with erlfmt
+        if: ${{ matrix.os == 'ubuntu-latest' }}
+        run: rebar3 fmt --check
+        continue-on-error: true
       - name: Compile
         run: rebar3 compile
       - name: EUnit tests
         run: rebar3 eunit
+      - name: Restore dialyzer PLT from cache
+        uses: actions/cache@v2
+        with:
+          path: ~/.cache/rebar3/rebar3_*_plt
+          key: ${{ runner.os }}-${{ steps.setup-beam.outputs.otp-version }}

Review comment:
       Oh good find. That did take a bit to build locally




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org