You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "JackieTien97 (via GitHub)" <gi...@apache.org> on 2024/08/29 02:54:24 UTC
[PR] Add constant folding feature to table model [iotdb]
JackieTien97 opened a new pull request, #13333:
URL: https://github.com/apache/iotdb/pull/13333
1. Add constant folding feature to table model
a. only support cast、in expression in this pr, but with this arch we can simply support other built-in functions and operators
3. change the tsfile dependency version to fix a bug while pushing in filter down to scan
4. Support cast a string to Timestamp type
5. Add a new Rule called RemoveTrivialFilters to remove FilterNode whose predicate evaluated to `true` after constant folding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add constant folding feature to table model [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #13333:
URL: https://github.com/apache/iotdb/pull/13333#issuecomment-2317784982
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/13333?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `40.26201%` with `684 lines` in your changes missing coverage. Please review.
> Project coverage is 41.01%. Comparing base [(`861339b`)](https://app.codecov.io/gh/apache/iotdb/commit/861339b15580a5c6391a636c08c2aa66a6789975?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`a2fdaf8`)](https://app.codecov.io/gh/apache/iotdb/commit/a2fdaf8d3edc996187887bae996eba7783e51131?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 21 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/13333?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...an/relational/planner/IrExpressionInterpreter.java](https://app.codecov.io/gh/apache/iotdb/pull/13333?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Frelational%2Fplanner%2FIrExpressionInterpreter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9yZWxhdGlvbmFsL3BsYW5uZXIvSXJFeHByZXNzaW9uSW50ZXJwcmV0ZXIuamF2YQ==) | 38.14% | [253 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ssion/multi/builtin/helper/CastFunctionHelper.java](https://app.codecov.io/gh/apache/iotdb/pull/13333?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fexpression%2Fmulti%2Fbuiltin%2Fhelper%2FCastFunctionHelper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9leHByZXNzaW9uL211bHRpL2J1aWx0aW4vaGVscGVyL0Nhc3RGdW5jdGlvbkhlbHBlci5qYXZh) | 0.00% | [99 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../relational/planner/ir/ExpressionTreeRewriter.java](https://app.codecov.io/gh/apache/iotdb/pull/13333?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Frelational%2Fplanner%2Fir%2FExpressionTreeRewriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9yZWxhdGlvbmFsL3BsYW5uZXIvaXIvRXhwcmVzc2lvblRyZWVSZXdyaXRlci5qYXZh) | 31.30% | [79 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...engine/plan/relational/planner/IrTypeAnalyzer.java](https://app.codecov.io/gh/apache/iotdb/pull/13333?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Frelational%2Fplanner%2FIrTypeAnalyzer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9yZWxhdGlvbmFsL3BsYW5uZXIvSXJUeXBlQW5hbHl6ZXIuamF2YQ==) | 52.25% | [74 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...tive/rule/PushDownNegationsExpressionRewriter.java](https://app.codecov.io/gh/apache/iotdb/pull/13333?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Frelational%2Fplanner%2Fiterative%2Frule%2FPushDownNegationsExpressionRewriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9yZWxhdGlvbmFsL3BsYW5uZXIvaXRlcmF0aXZlL3J1bGUvUHVzaERvd25OZWdhdGlvbnNFeHByZXNzaW9uUmV3cml0ZXIuamF2YQ==) | 27.02% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...execution/relational/ColumnTransformerBuilder.java](https://app.codecov.io/gh/apache/iotdb/pull/13333?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fexecution%2Frelational%2FColumnTransformerBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvZXhlY3V0aW9uL3JlbGF0aW9uYWwvQ29sdW1uVHJhbnNmb3JtZXJCdWlsZGVyLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../plan/relational/metadata/FunctionNullability.java](https://app.codecov.io/gh/apache/iotdb/pull/13333?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Frelational%2Fmetadata%2FFunctionNullability.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9yZWxhdGlvbmFsL21ldGFkYXRhL0Z1bmN0aW9uTnVsbGFiaWxpdHkuamF2YQ==) | 0.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...iterative/rule/CanonicalizeExpressionRewriter.java](https://app.codecov.io/gh/apache/iotdb/pull/13333?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Frelational%2Fplanner%2Fiterative%2Frule%2FCanonicalizeExpressionRewriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9yZWxhdGlvbmFsL3BsYW5uZXIvaXRlcmF0aXZlL3J1bGUvQ2Fub25pY2FsaXplRXhwcmVzc2lvblJld3JpdGVyLmphdmE=) | 57.14% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...onal/planner/ir/NormalizeOrExpressionRewriter.java](https://app.codecov.io/gh/apache/iotdb/pull/13333?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Frelational%2Fplanner%2Fir%2FNormalizeOrExpressionRewriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9yZWxhdGlvbmFsL3BsYW5uZXIvaXIvTm9ybWFsaXplT3JFeHByZXNzaW9uUmV3cml0ZXIuamF2YQ==) | 23.52% | [13 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...lational/function/ResolvedFunctionCallBuilder.java](https://app.codecov.io/gh/apache/iotdb/pull/13333?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Frelational%2Ffunction%2FResolvedFunctionCallBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9yZWxhdGlvbmFsL2Z1bmN0aW9uL1Jlc29sdmVkRnVuY3Rpb25DYWxsQnVpbGRlci5qYXZh) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [15 more](https://app.codecov.io/gh/apache/iotdb/pull/13333?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #13333 +/- ##
============================================
- Coverage 41.03% 41.01% -0.02%
Complexity 71 71
============================================
Files 3924 3943 +19
Lines 241627 243237 +1610
Branches 29153 29417 +264
============================================
+ Hits 99145 99767 +622
- Misses 142482 143470 +988
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/13333?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add constant folding feature to table model [iotdb]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #13333:
URL: https://github.com/apache/iotdb/pull/13333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add constant folding feature to table model [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #13333:
URL: https://github.com/apache/iotdb/pull/13333#issuecomment-2316622556
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13333) **Quality Gate failed**
Failed conditions
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13333) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13333)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add constant folding feature to table model [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #13333:
URL: https://github.com/apache/iotdb/pull/13333#issuecomment-2317642027
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13333) **Quality Gate failed**
Failed conditions
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13333) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13333)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org