You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by tr...@apache.org on 2018/11/17 10:04:01 UTC
[flink] branch release-1.7 updated: [FLINK-10906][docker] Don't
print configuration in docker-entrypoint.sh
This is an automated email from the ASF dual-hosted git repository.
trohrmann pushed a commit to branch release-1.7
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/release-1.7 by this push:
new 1acf5ee [FLINK-10906][docker] Don't print configuration in docker-entrypoint.sh
1acf5ee is described below
commit 1acf5ee2a4beb11a0460d71e2052060d0ddba4f0
Author: Till Rohrmann <tr...@apache.org>
AuthorDate: Fri Nov 16 16:38:55 2018 +0100
[FLINK-10906][docker] Don't print configuration in docker-entrypoint.sh
In order to not leak secrets we should not print the configuration in docker-entrypoint.sh.
---
flink-container/docker/docker-entrypoint.sh | 1 -
flink-contrib/docker-flink/docker-entrypoint.sh | 2 --
2 files changed, 3 deletions(-)
diff --git a/flink-container/docker/docker-entrypoint.sh b/flink-container/docker/docker-entrypoint.sh
index 85ba866..0bf7c04 100755
--- a/flink-container/docker/docker-entrypoint.sh
+++ b/flink-container/docker/docker-entrypoint.sh
@@ -32,7 +32,6 @@ if [ "${CMD}" == "--help" -o "${CMD}" == "-h" ]; then
exit 0
elif [ "${CMD}" == "${JOB_CLUSTER}" -o "${CMD}" == "${TASK_MANAGER}" ]; then
echo "Starting the ${CMD}"
- echo "config file: " && grep '^[^\n#]' $FLINK_HOME/conf/flink-conf.yaml
if [ "${CMD}" == "${TASK_MANAGER}" ]; then
exec $FLINK_HOME/bin/taskmanager.sh start-foreground "$@"
diff --git a/flink-contrib/docker-flink/docker-entrypoint.sh b/flink-contrib/docker-flink/docker-entrypoint.sh
index 1edf99c..a4e279f 100755
--- a/flink-contrib/docker-flink/docker-entrypoint.sh
+++ b/flink-contrib/docker-flink/docker-entrypoint.sh
@@ -29,7 +29,6 @@ elif [ "$1" == "jobmanager" ]; then
echo "Starting Job Manager"
sed -i -e "s/jobmanager.rpc.address: localhost/jobmanager.rpc.address: ${JOB_MANAGER_RPC_ADDRESS}/g" $FLINK_HOME/conf/flink-conf.yaml
- echo "config file: " && grep '^[^\n#]' $FLINK_HOME/conf/flink-conf.yaml
exec $FLINK_HOME/bin/jobmanager.sh start-foreground
elif [ "$1" == "taskmanager" ]; then
@@ -37,7 +36,6 @@ elif [ "$1" == "taskmanager" ]; then
sed -i -e "s/taskmanager.numberOfTaskSlots: 1/taskmanager.numberOfTaskSlots: $(grep -c ^processor /proc/cpuinfo)/g" $FLINK_HOME/conf/flink-conf.yaml
echo "Starting Task Manager"
- echo "config file: " && grep '^[^\n#]' $FLINK_HOME/conf/flink-conf.yaml
exec $FLINK_HOME/bin/taskmanager.sh start-foreground
fi