[GitHub] [superset] ktmud commented on a change in pull request #13592: chore: Refactor code quality issues

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #13592:
URL: https://github.com/apache/superset/pull/13592#discussion_r598143682



##########
File path: tests/dict_import_export_tests.py
##########
@@ -66,8 +66,12 @@ def tearDownClass(cls):
         cls.delete_imports()
 
     def create_table(
-        self, name, schema="", id=0, cols_names=[], cols_uuids=None, metric_names=[]
+        self, name, schema="", id=0, cols_names=None, cols_uuids=None, metric_names=None

Review comment:
       Pylint is already capable of capture this error. We just didn't enable it for tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org