You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by maryannxue <gi...@git.apache.org> on 2014/02/21 04:16:10 UTC
[GitHub] incubator-phoenix pull request: Add Option "FAVOR_STAR_JOIN" to in...
GitHub user maryannxue opened a pull request:
https://github.com/apache/incubator-phoenix/pull/9
Add Option "FAVOR_STAR_JOIN" to indicate if star join optimization is preferred for multi inner join queries
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maryannxue/incubator-phoenix master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-phoenix/pull/9.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9
----
commit 05b584181fe36102feca765886fcda75b770b2b2
Author: maryannxue <ma...@apache.org>
Date: 2014-02-12T21:41:53Z
Fix PHOENIX-44 Cannot create index on tables with case-sensitive schema names
commit 02af57c96476c9d205d07ba96974c49188a282fa
Author: maryannxue <ma...@apache.org>
Date: 2014-02-21T02:54:17Z
Merge remote-tracking branch 'asf/master'
commit bd20346da5336d3d240493fdbfbcd5cc03280810
Author: maryannxue <ma...@apache.org>
Date: 2014-02-21T03:08:23Z
PHOENIX-68 Add Option "FAVOR_STAR_JOIN" to indicate if star join optimization is preferred for multi inner join queries
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---
[GitHub] incubator-phoenix pull request: PHOENIX-68 Add Option "FAVOR_STAR_...
Posted by maryannxue <gi...@git.apache.org>.
Github user maryannxue closed the pull request at:
https://github.com/apache/incubator-phoenix/pull/9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-phoenix pull request: PHOENIX-68 Add Option "FAVOR_STAR_...
Posted by maryannxue <gi...@git.apache.org>.
GitHub user maryannxue reopened a pull request:
https://github.com/apache/incubator-phoenix/pull/9
PHOENIX-68 Add Option "FAVOR_STAR_JOIN" to indicate if star join optimization is preferred for multi inner join queries
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maryannxue/incubator-phoenix master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-phoenix/pull/9.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9
----
commit 05b584181fe36102feca765886fcda75b770b2b2
Author: maryannxue <ma...@apache.org>
Date: 2014-02-12T21:41:53Z
Fix PHOENIX-44 Cannot create index on tables with case-sensitive schema names
commit 02af57c96476c9d205d07ba96974c49188a282fa
Author: maryannxue <ma...@apache.org>
Date: 2014-02-21T02:54:17Z
Merge remote-tracking branch 'asf/master'
commit bd20346da5336d3d240493fdbfbcd5cc03280810
Author: maryannxue <ma...@apache.org>
Date: 2014-02-21T03:08:23Z
PHOENIX-68 Add Option "FAVOR_STAR_JOIN" to indicate if star join optimization is preferred for multi inner join queries
commit 9a2ced8936d6cedbc44a4ed2de2c6f72f4f4307f
Author: maryannxue <ma...@apache.org>
Date: 2014-02-21T04:59:29Z
PHOENIX-68 Add Option "FAVOR_STAR_JOIN" to indicate if star join optimization is preferred for multi inner join queries
commit 20a97904e48829f8b412bcfb0ac2084259133126
Author: maryannxue <ma...@apache.org>
Date: 2014-02-21T05:53:21Z
PHOENIX-68 Add Option "FAVOR_STAR_JOIN" to indicate if star join optimization is preferred for multi inner join queries
commit 7568516fabfb416f5dcbfa89468b839963802a87
Author: maryannxue <ma...@apache.org>
Date: 2014-02-21T22:14:14Z
Revert "PHOENIX-68 Add Option "FAVOR_STAR_JOIN" to indicate if star join optimization is preferred for multi inner join queries"
This reverts commit 20a97904e48829f8b412bcfb0ac2084259133126.
commit 3fb95819959d22deb2c03e895d976e7d933007f2
Author: maryannxue <ma...@apache.org>
Date: 2014-02-21T22:14:56Z
Revert "PHOENIX-68 Add Option "FAVOR_STAR_JOIN" to indicate if star join optimization is preferred for multi inner join queries"
This reverts commit 9a2ced8936d6cedbc44a4ed2de2c6f72f4f4307f.
commit ca0b55d048a6c547a5d6b081dd84dea01011e5c1
Author: maryannxue <ma...@apache.org>
Date: 2014-02-21T22:16:13Z
Revert "PHOENIX-68 Add Option "FAVOR_STAR_JOIN" to indicate if star join optimization is preferred for multi inner join queries"
This reverts commit bd20346da5336d3d240493fdbfbcd5cc03280810.
commit c4df65791a163070362662aad7ce5916faa3c3d7
Author: maryannxue <ma...@apache.org>
Date: 2014-02-21T22:18:13Z
Merge remote-tracking branch 'asf/master'
commit 9b5df132480b6bd25c0c33dd818278a5fc1b3f55
Author: maryannxue <ma...@apache.org>
Date: 2014-02-21T22:22:38Z
PHOENIX-68 Add Option "FAVOR_STAR_JOIN" to indicate if star join optimization is preferred for multi inner join queries
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---
[GitHub] incubator-phoenix pull request: PHOENIX-68 Add Option "FAVOR_STAR_...
Posted by JamesRTaylor <gi...@git.apache.org>.
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/9#discussion_r9966746
--- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java ---
@@ -1056,36 +1099,6 @@ private static SelectStatement getSubqueryForOptimizedPlan(SelectStatement selec
return NODE_FACTORY.select(from, select.getHint(), false, selectList, where, groupBy, null, orderBy, null, 0, false);
}
- /**
--- End diff --
Just curious on the reason for the removal of this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---
[GitHub] incubator-phoenix pull request: PHOENIX-68 Add Option "FAVOR_STAR_...
Posted by JamesRTaylor <gi...@git.apache.org>.
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/9#discussion_r9966798
--- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java ---
@@ -1056,36 +1099,6 @@ private static SelectStatement getSubqueryForOptimizedPlan(SelectStatement selec
return NODE_FACTORY.select(from, select.getHint(), false, selectList, where, groupBy, null, orderBy, null, 0, false);
}
- /**
--- End diff --
Never mind - I see it was just moved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---
[GitHub] incubator-phoenix pull request: PHOENIX-68 Add Option "FAVOR_STAR_...
Posted by maryannxue <gi...@git.apache.org>.
Github user maryannxue closed the pull request at:
https://github.com/apache/incubator-phoenix/pull/9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---
[GitHub] incubator-phoenix pull request: PHOENIX-68 Add Option "FAVOR_STAR_...
Posted by JamesRTaylor <gi...@git.apache.org>.
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/9#issuecomment-35785029
+1 Maryann. Couple of minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---
[GitHub] incubator-phoenix pull request: PHOENIX-68 Add Option "FAVOR_STAR_...
Posted by maryannxue <gi...@git.apache.org>.
Github user maryannxue commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/9#issuecomment-35787756
Fixed. Thank you for the comments, James!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---
[GitHub] incubator-phoenix pull request: PHOENIX-68 Add Option "FAVOR_STAR_...
Posted by JamesRTaylor <gi...@git.apache.org>.
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/9#discussion_r9966869
--- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java ---
@@ -135,7 +140,7 @@ private JoinSpec(SelectStatement statement, ColumnResolver resolver) throws SQLE
if (!(tableNode instanceof JoinTableNode))
throw new SQLFeatureNotSupportedException("Implicit joins not supported.");
JoinTableNode joinTableNode = (JoinTableNode) tableNode;
- JoinTable joinTable = new JoinTable(joinTableNode, tableRefIter.next(), selectList, resolver);
+ JoinTable joinTable = new JoinTable(joinTableNode, tableRefIter.next(), selectList, hint, resolver);
--- End diff --
To try to keep args down, how about passing through the SelectStatement instead of selectList and hint, as you can get both of them from that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---