[GitHub] [james-project] vttranlina commented on a diff in pull request #1479: JAMES-3891 Graceful shutdown for queue consumers [3.7.x]

["vttranlina (via GitHub)" <gi...@apache.org>]

vttranlina commented on code in PR #1479:
URL: https://github.com/apache/james-project/pull/1479#discussion_r1138367482


##########
server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remote/delivery/DeliveryRunnable.java:
##########
@@ -204,6 +210,12 @@ private Duration getNextDelay(int retryCount) {
     @Override
     public void dispose() {
         disposable.dispose();
+
+        Awaitility.await()

Review Comment:
   Should we move it in try catch block?
   I worry after 2 seconds, it will throw an exception, 
   then the bellow code will not be run
   ```
    remoteDeliveryProcessScheduler.dispose();
    remoteDeliveryDequeueScheduler.dispose();
   ```
   
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org