You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/26 12:57:17 UTC

[GitHub] [arrow] jonkeane commented on a diff in pull request #12992: ARROW-16325: [R] Add task for R package with gcc12

jonkeane commented on code in PR #12992:
URL: https://github.com/apache/arrow/pull/12992#discussion_r858668973


##########
dev/tasks/tasks.yml:
##########
@@ -1321,13 +1321,13 @@ tasks:
       image: ubuntu-r-only-r
 
   # This also has -flto=auto
-  test-r-gcc-11:
+  test-r-gcc-12:
     ci: github
     template: docker-tests/github.linux.yml
     params:
       env:
         UBUNTU: 22.04
-        GCC_VERSION: 11
+        GCC_VERSION: 12

Review Comment:
   Do we know if we have gcc 11 coverage in a different build? I can look and see if you don't off the top of your head. But if we _don't_ we might want to duplicate these and do both 11 and 12.



##########
dev/tasks/tasks.yml:
##########
@@ -1321,13 +1321,13 @@ tasks:
       image: ubuntu-r-only-r
 
   # This also has -flto=auto
-  test-r-gcc-11:
+  test-r-gcc-12:
     ci: github
     template: docker-tests/github.linux.yml
     params:
       env:
         UBUNTU: 22.04
-        GCC_VERSION: 11
+        GCC_VERSION: 12
       # S3 support is not buildable with gcc11 right now
       flags: '-e ARROW_S3=OFF'

Review Comment:
   Would you mind also trying to drop this line and see if it builds? I suspect it won't, but it's possible that the aws sdk + gcc build issues have been resolved by now (and we bumped the sdk version enough that we don't run into the old ones)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org