[jira] Updated: (ZOOKEEPER-409) address all findbugs warnings in jute related classes

["Patrick Hunt (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-409:
-----------------------------------

    Attachment: ZOOKEEPER-409.patch

This cleans up the findbugs warnings for jute and jute related files.

Note in particular:

1) added EI/EI2 "exposing internals" to the jute generated classes. we only use those internally
and the fact that internals are exposed is not a problem for us (although would be good to
fix at some point - like avro)
2) compareTo for vector/map based jute generated classes was wrong
3) removed @author tags while I was at it (we don't allow)

> address all findbugs warnings in jute related classes
> -----------------------------------------------------
>
>                 Key: ZOOKEEPER-409
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-409
>             Project: Zookeeper
>          Issue Type: Sub-task
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-409.patch
>
>
> trunk/src/java/main/org/apache/jute/XmlInputArchive.java
> trunk/src/java/main/org/apache/jute/compiler/JFile.java
> trunk/src/java/main/org/apache/jute/compiler/JRecord.java
> trunk/src/java/main/org/apache/jute/compiler/CGenerator.java
> trunk/src/java/main/org/apache/jute/compiler/CppGenerator.java
> trunk/src/java/main/org/apache/jute/compiler/JavaGenerator.java
> org/apache/zookeeper/proto/AuthPacket.java
> org/apache/zookeeper/proto/ConnectRequest.java
> org/apache/zookeeper/proto/ConnectResponse.java
> org/apache/zookeeper/proto/CreateRequest.java
> org/apache/zookeeper/proto/GetChildrenResponse.java
> org/apache/zookeeper/proto/GetDataResponse.java
> org/apache/zookeeper/proto/SetDataRequest.java
> org/apache/zookeeper/proto/op_result_t.java
> org/apache/zookeeper/server/quorum/QuorumPacket.java
> org/apache/zookeeper/txn/CreateTxn.java
> org/apache/zookeeper/txn/SetDataTxn.java

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.