You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2015/12/17 01:51:11 UTC
Re: Review Request 41455: RANGER-789: fix incorrect policy list
paging for non-admin users
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41455/
-----------------------------------------------------------
(Updated Dec. 17, 2015, 12:51 a.m.)
Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Changes
-------
Updated to support policy filtering by polResource and policyNamePartial
Bugs: RANGER-789
https://issues.apache.org/jira/browse/RANGER-789
Repository: ranger
Description
-------
Policy retrieval is updated to fix the incorrect policy list for non-admin users
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractPredicateUtil.java abfb350
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 54e61f1
security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 141e634
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 7d41f07
security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java 339f1e7
Diff: https://reviews.apache.org/r/41455/diff/
Testing
-------
Verified that policy list paging works correctly for non-admin users as well, by doing the following:
- created large number of policies, say 1500
- every 20th policy had delgated-admin access for a non-admin user - user1
- login as user1 and view the policies
- verified that the first page shows full list of policies that user1 has delegated-admin access to; before this fix, the first page would list only 2 policies
- verified that there is no change to policy listing for admin users
Thanks,
Madhan Neethiraj