You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/08/03 13:18:24 UTC
[GitHub] [airflow] potiuk opened a new pull request, #33070: Allows to choose SSL context for SMTP connection
potiuk opened a new pull request, #33070:
URL: https://github.com/apache/airflow/pull/33070
This change add two options to choose from when SSL SMTP connection is created:
* default - for balance between compatibility and security
* none - in case compatibility with existing infrastructure is preferred
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #33070: Allows to choose SSL context for SMTP connection
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #33070:
URL: https://github.com/apache/airflow/pull/33070#discussion_r1283198673
##########
airflow/config_templates/config.yml:
##########
@@ -1862,6 +1862,22 @@ email:
type: string
example: "Airflow <ai...@example.com>"
default: ~
+ ssl_context:
+ description: |
+ ssl context to use when using SMTP and IMAP SSL connections. By default, the context is "default"
+ which sets it to ``ssl.create_default_context()`` which provides the right balance between
+ compatibility and security, it however requires that certificates in your operating system are
+ updated and that SMTP/IMAP servers of yours have valid certificates that have corresponding public
+ keys installed on your machines. You can switch it to "none" if you want to disable checking
+ of the certificates, but it is not recommended as it allows MITM (man-in-the-middle) attacks
+ if your infrastructure is not sufficiently secured. It should only be set temporarily while you
+ are fixing your certificate configuration. This can be typically done by upgrading to newer
+ version of the operating system you run Airflow components on,by upgrading/refreshing proper
+ certificates in the OS or by updating certificates for your mail servers.
+ type: string
+ version_added: 2.7.0
Review Comment:
Mmm do we want to add this as config?
We have WIP PR to extract smtp logic from core to providers
https://github.com/apache/airflow/pull/30531/files
cc @hussein-awala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala commented on a diff in pull request #33070: Allows to choose SSL context for SMTP connection
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on code in PR #33070:
URL: https://github.com/apache/airflow/pull/33070#discussion_r1283273058
##########
airflow/config_templates/config.yml:
##########
@@ -1862,6 +1862,22 @@ email:
type: string
example: "Airflow <ai...@example.com>"
default: ~
+ ssl_context:
+ description: |
+ ssl context to use when using SMTP and IMAP SSL connections. By default, the context is "default"
+ which sets it to ``ssl.create_default_context()`` which provides the right balance between
+ compatibility and security, it however requires that certificates in your operating system are
+ updated and that SMTP/IMAP servers of yours have valid certificates that have corresponding public
+ keys installed on your machines. You can switch it to "none" if you want to disable checking
+ of the certificates, but it is not recommended as it allows MITM (man-in-the-middle) attacks
+ if your infrastructure is not sufficiently secured. It should only be set temporarily while you
+ are fixing your certificate configuration. This can be typically done by upgrading to newer
+ version of the operating system you run Airflow components on,by upgrading/refreshing proper
+ certificates in the OS or by updating certificates for your mail servers.
+ type: string
+ version_added: 2.7.0
Review Comment:
it's fine to merge this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #33070: Allows to choose SSL context for SMTP connection
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #33070:
URL: https://github.com/apache/airflow/pull/33070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #33070: Allows to choose SSL context for SMTP connection
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #33070:
URL: https://github.com/apache/airflow/pull/33070#discussion_r1283200436
##########
airflow/config_templates/config.yml:
##########
@@ -1862,6 +1862,22 @@ email:
type: string
example: "Airflow <ai...@example.com>"
default: ~
+ ssl_context:
+ description: |
+ ssl context to use when using SMTP and IMAP SSL connections. By default, the context is "default"
+ which sets it to ``ssl.create_default_context()`` which provides the right balance between
+ compatibility and security, it however requires that certificates in your operating system are
+ updated and that SMTP/IMAP servers of yours have valid certificates that have corresponding public
+ keys installed on your machines. You can switch it to "none" if you want to disable checking
+ of the certificates, but it is not recommended as it allows MITM (man-in-the-middle) attacks
+ if your infrastructure is not sufficiently secured. It should only be set temporarily while you
+ are fixing your certificate configuration. This can be typically done by upgrading to newer
+ version of the operating system you run Airflow components on,by upgrading/refreshing proper
+ certificates in the OS or by updating certificates for your mail servers.
+ type: string
+ version_added: 2.7.0
Review Comment:
Not yet. This is 2.7.0 change. We will follow up with providers as next step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org