You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by "jiatao.tao (JIRA)" <ji...@apache.org> on 2018/08/05 11:23:00 UTC

[jira] [Commented] (KYLIN-3417) Consider replacing ReentrantReadWriteLock with StampedLock

    [ https://issues.apache.org/jira/browse/KYLIN-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569436#comment-16569436 ] 

jiatao.tao commented on KYLIN-3417:
-----------------------------------

Hi [~yuzhihong@gmail.com] , nowadays, kylin's minimum java version requirement is sitll 1.7, when it comes to 1.8, we can replace ReentrantReadWriteLock in class AutoReadWriteLock with StampedLock.


> Consider replacing ReentrantReadWriteLock with StampedLock
> ----------------------------------------------------------
>
>                 Key: KYLIN-3417
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3417
>             Project: Kylin
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: jiatao.tao
>            Priority: Major
>             Fix For: v2.5.0
>
>
> ReentrantReadWriteLock's are only the right solution when there is long hold time due to expensive I/O.
> It is expensive for readers.
> We should see if the lighter {{StampedLock}} can be used instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)