[GitHub] [cassandra] maedhroz commented on a change in pull request #1323: CASSANDRA-17155: Increase the buckets count for timer histogram

[GitBox <gi...@apache.org>]

maedhroz commented on a change in pull request #1323:
URL: https://github.com/apache/cassandra/pull/1323#discussion_r750466232



##########
File path: src/java/org/apache/cassandra/metrics/DecayingEstimatedHistogramReservoir.java
##########
@@ -83,6 +83,7 @@
      * The default number of decayingBuckets. Use this bucket count to reduce memory allocation for bucket offsets.
      */
     public static final int DEFAULT_BUCKET_COUNT = 164;
+    public static final int FEWER_BUCKET_COUNT = 127;

Review comment:
       This is a fun naming problem. (Completely non-binding) alternatives could be `LOW_BUCKET_COUNT` or `MICRO_LATENCY_BUCKET_COUNT`. I'm fine with whatever you think sounds best though.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org