You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/04 09:28:20 UTC
[GitHub] [incubator-doris] hf200012 opened a new pull request, #9363: [fix]Stream load 307 temporary redirection authentication information is lost
hf200012 opened a new pull request, #9363:
URL: https://github.com/apache/incubator-doris/pull/9363
Stream load 307 temporary redirection authentication information is lost
# Proposed changes
Issue Number: close #8100
https://github.com/apache/incubator-doris/issues/8100
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9363: [fix]Stream load 307 temporary redirection authentication information is lost
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9363:
URL: https://github.com/apache/incubator-doris/pull/9363#issuecomment-1117379348
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9363: [fix]Stream load 307 temporary redirection authentication information is lost
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9363:
URL: https://github.com/apache/incubator-doris/pull/9363#issuecomment-1120128032
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9363: [fix]Stream load 307 temporary redirection authentication information is lost
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9363:
URL: https://github.com/apache/incubator-doris/pull/9363#issuecomment-1117379380
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #9363: [fix]Stream load 307 temporary redirection authentication information is lost
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9363:
URL: https://github.com/apache/incubator-doris/pull/9363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] hf200012 commented on a diff in pull request #9363: [fix]Stream load 307 temporary redirection authentication information is lost
Posted by GitBox <gi...@apache.org>.
hf200012 commented on code in PR #9363:
URL: https://github.com/apache/incubator-doris/pull/9363#discussion_r867297478
##########
fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/RestBaseController.java:
##########
@@ -77,9 +77,10 @@ public RedirectView redirectTo(HttpServletRequest request, TNetworkAddress addr)
ActionAuthorizationInfo authInfo = getAuthorizationInfo(request);
// Fix username@cluster:passwod is modified to cluster: username:passwod causes authentication failure
// @see https://github.com/apache/incubator-doris/issues/8100
- userInfo = ClusterNamespace.getNameFromFullName(authInfo.fullUserName) +
- "@" + ClusterNamespace.getClusterNameFromFullName(authInfo.fullUserName) +
- ":" + authInfo.password;
+ String clusterName = ConnectContext.get().getClusterName();
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a diff in pull request #9363: [fix]Stream load 307 temporary redirection authentication information is lost
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #9363:
URL: https://github.com/apache/incubator-doris/pull/9363#discussion_r864836209
##########
fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/RestBaseController.java:
##########
@@ -77,9 +77,10 @@ public RedirectView redirectTo(HttpServletRequest request, TNetworkAddress addr)
ActionAuthorizationInfo authInfo = getAuthorizationInfo(request);
// Fix username@cluster:passwod is modified to cluster: username:passwod causes authentication failure
// @see https://github.com/apache/incubator-doris/issues/8100
- userInfo = ClusterNamespace.getNameFromFullName(authInfo.fullUserName) +
- "@" + ClusterNamespace.getClusterNameFromFullName(authInfo.fullUserName) +
- ":" + authInfo.password;
+ String clusterName = ConnectContext.get().getClusterName();
Review Comment:
Change the comment to:
```
The final redirect userInfo format is like:
username@cluster:password
This format will be parsed at BaseController#parseAuthInfo
```
##########
fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/RestBaseController.java:
##########
@@ -77,9 +77,10 @@ public RedirectView redirectTo(HttpServletRequest request, TNetworkAddress addr)
ActionAuthorizationInfo authInfo = getAuthorizationInfo(request);
// Fix username@cluster:passwod is modified to cluster: username:passwod causes authentication failure
// @see https://github.com/apache/incubator-doris/issues/8100
- userInfo = ClusterNamespace.getNameFromFullName(authInfo.fullUserName) +
- "@" + ClusterNamespace.getClusterNameFromFullName(authInfo.fullUserName) +
- ":" + authInfo.password;
+ String clusterName = ConnectContext.get().getClusterName();
Review Comment:
```suggestion
String clusterName = ConnectContext.get() == null ? SystemInfoService.DEFAULT_CLUSTER : ConnectContext.get().getClusterName();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org