You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datalab.apache.org by yt...@apache.org on 2021/03/24 07:59:11 UTC
[incubator-datalab] branch DATALAB-2332 created (now 14671d5)
This is an automated email from the ASF dual-hosted git repository.
ytykhun pushed a change to branch DATALAB-2332
in repository https://gitbox.apache.org/repos/asf/incubator-datalab.git.
at 14671d5 [DATALAB-2332] removed extra scrollbar after clicking on gear icon
This branch includes the following new commits:
new 14671d5 [DATALAB-2332] removed extra scrollbar after clicking on gear icon
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datalab.apache.org
For additional commands, e-mail: commits-help@datalab.apache.org
[incubator-datalab] 01/01: [DATALAB-2332] removed extra scrollbar
after clicking on gear icon
Posted by yt...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ytykhun pushed a commit to branch DATALAB-2332
in repository https://gitbox.apache.org/repos/asf/incubator-datalab.git
commit 14671d540ddd8492b93b2cf0102cf47ae2d8020e
Author: Yurii Tykhun <ty...@gmail.com>
AuthorDate: Wed Mar 24 09:58:50 2021 +0200
[DATALAB-2332] removed extra scrollbar after clicking on gear icon
---
.../main/resources/webapp/src/app/shared/bubble/bubble.component.ts | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/services/self-service/src/main/resources/webapp/src/app/shared/bubble/bubble.component.ts b/services/self-service/src/main/resources/webapp/src/app/shared/bubble/bubble.component.ts
index 9bc17f5..9b8dba1 100644
--- a/services/self-service/src/main/resources/webapp/src/app/shared/bubble/bubble.component.ts
+++ b/services/self-service/src/main/resources/webapp/src/app/shared/bubble/bubble.component.ts
@@ -90,7 +90,10 @@ export class BubbleComponent implements OnDestroy {
if (this.alternative) {
this.changeDirection = !this.isInViewport(bubbleElem);
- this.changeDirection && this.bubbleService.updatePosition(element, bubbleElem, this.alternative);
+
+ const isBubbleOutOfWrapper = bubbleElem.getBoundingClientRect().bottom > document.querySelector('.wrapper').getBoundingClientRect().bottom;
+
+ (this.changeDirection || isBubbleOutOfWrapper) && this.bubbleService.updatePosition(element, bubbleElem, this.alternative);
}
this.ref.markForCheck();
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datalab.apache.org
For additional commands, e-mail: commits-help@datalab.apache.org