You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2017/08/18 19:24:05 UTC

[GitHub] spark pull request #18995: [SPARK-21787][SQL] Support for pushing down filte...

GitHub user dongjoon-hyun opened a pull request:

    https://github.com/apache/spark/pull/18995

    [SPARK-21787][SQL] Support for pushing down filters for DateType in ORC

    ## What changes were proposed in this pull request?
    
    This PR supports pushwing down DateType filters in ORC. This PR depends on #18953 , but it's still under review. After merging #18953, I will enable the new test case in this PR.
    
    ## How was this patch tested?
    
    The test is marked as ignored.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongjoon-hyun/spark SPARK-21787

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18995.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18995
    
----
commit 7f63202e858141319e8d01e9170303cee771a9eb
Author: Dongjoon Hyun <do...@apache.org>
Date:   2017-08-18T19:13:15Z

    [SPARK-21787][SQL] Support for pushing down filters for DateType in ORC

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #18995: [SPARK-21787][SQL] Support for pushing down filte...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18995#discussion_r154537824
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala ---
    @@ -0,0 +1,362 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.execution.datasources.orc
    +
    +import java.nio.charset.StandardCharsets
    +import java.sql.{Date, Timestamp}
    +
    +import scala.collection.JavaConverters._
    +
    +import org.apache.orc.storage.ql.io.sarg.{PredicateLeaf, SearchArgument}
    --- End diff --
    
    Please note that this suite use Apache ORC `SearchArgument` and `PredicateLeaf` classes.
    We cannot share the test code for this suite.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    **[Test build #84609 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84609/testReport)** for PR 18995 at commit [`18accdd`](https://github.com/apache/spark/commit/18accdde87a158d5fa8d62caec121c152dff07d4).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    **[Test build #80854 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80854/testReport)** for PR 18995 at commit [`7f63202`](https://github.com/apache/spark/commit/7f63202e858141319e8d01e9170303cee771a9eb).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SPARK-22672][SQL] Support for pushing down...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84405/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SPARK-22672][SQL] Support for pushing down...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    **[Test build #84405 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84405/testReport)** for PR 18995 at commit [`9f6d75b`](https://github.com/apache/spark/commit/9f6d75bece86233baeb277c95b1974ac207c0d32).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    Hi, @cloud-fan .
    This is the first followup after #19651 .
    Could you review this PR, too?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    **[Test build #80854 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80854/testReport)** for PR 18995 at commit [`7f63202`](https://github.com/apache/spark/commit/7f63202e858141319e8d01e9170303cee771a9eb).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [WIP][SPARK-21787][SQL] Support for pushing down filters...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83700/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    **[Test build #80857 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80857/testReport)** for PR 18995 at commit [`b31acc5`](https://github.com/apache/spark/commit/b31acc5ac5b34fcc8868252a7e3217b959c6d6d8).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SPARK-22672][SQL] Support for pushing down...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    @cloud-fan .
    
    For the other part, I'm restructuring to remove redundancy in the same manner of `InMemoryCatalogedDDLSuite`, `HiveCatalogedDDLSuite`, and `DDLSuite`.
    
    This one cannot be the part of that restructuring, because the test function signatures are different due to `PredicateLeaf` and `SearchArgument`.
    
    Could you review this first?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84609/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SPARK-22672][SQL] Support for pushing down...

Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    maybe have a PR to move the tests first?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    **[Test build #80857 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80857/testReport)** for PR 18995 at commit [`b31acc5`](https://github.com/apache/spark/commit/b31acc5ac5b34fcc8868252a7e3217b959c6d6d8).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #18995: [SPARK-21787][SQL] Support for pushing down filte...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18995#discussion_r154537895
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcTest.scala ---
    @@ -15,20 +15,21 @@
      * limitations under the License.
      */
     
    -package org.apache.spark.sql.hive.orc
    +package org.apache.spark.sql.execution.datasources.orc
     
     import java.io.File
     
     import scala.reflect.ClassTag
     import scala.reflect.runtime.universe.TypeTag
     
     import org.apache.spark.sql._
    -import org.apache.spark.sql.hive.test.TestHiveSingleton
     import org.apache.spark.sql.test.SQLTestUtils
     
    -private[sql] trait OrcTest extends SQLTestUtils with TestHiveSingleton {
    +abstract class OrcTest extends QueryTest with SQLTestUtils {
       import testImplicits._
     
    +  protected def format: String
    --- End diff --
    
    By using full canonical class names, we will explicitly test new OrcFileFormat in `sql/core` and old OrcFileFormat in `sql/hive` without considering SQL ORC switching conf.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SPARK-22672][SQL] Support for pushing down...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #18995: [SPARK-21787][SQL] Support for pushing down filte...

Posted by dongjoon-hyun <gi...@git.apache.org>.
GitHub user dongjoon-hyun reopened a pull request:

    https://github.com/apache/spark/pull/18995

    [SPARK-21787][SQL] Support for pushing down filters for DateType in ORC

    ## What changes were proposed in this pull request?
    
    This PR supports pushwing down DateType filters in ORC. This PR depends on #18953 . Since it's still under review, I didn't include that and added a `ignore` test case. After merging #18953, I will enable the new test case in this PR.
    
    ## How was this patch tested?
    
    The test is marked as ignored.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongjoon-hyun/spark SPARK-21787

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18995.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18995
    
----
commit 7f63202e858141319e8d01e9170303cee771a9eb
Author: Dongjoon Hyun <do...@apache.org>
Date:   2017-08-18T19:13:15Z

    [SPARK-21787][SQL] Support for pushing down filters for DateType in ORC

commit b31acc5ac5b34fcc8868252a7e3217b959c6d6d8
Author: Dongjoon Hyun <do...@apache.org>
Date:   2017-08-18T20:45:40Z

    Remove the negative test case.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [WIP][SPARK-21787][SQL] Support for pushing down filters...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    This will be supported in a new ORCFileFormat after merging #18953.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80854/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    thanks, merging to master!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    **[Test build #84609 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84609/testReport)** for PR 18995 at commit [`18accdd`](https://github.com/apache/spark/commit/18accdde87a158d5fa8d62caec121c152dff07d4).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #18995: [SPARK-21787][SQL] Support for pushing down filte...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18995#discussion_r154537798
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilters.scala ---
    @@ -82,8 +82,7 @@ private[orc] object OrcFilters {
        * Both CharType and VarcharType are cleaned at AstBuilder.
        */
       private def isSearchableType(dataType: DataType) = dataType match {
    -    // TODO: SPARK-21787 Support for pushing down filters for DateType in ORC
    -    case BinaryType | DateType => false
    --- End diff --
    
    This PR supports DateType PPD on new OrcFileFormat.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    Hi, @cloud-fan .
    Could you review this PR again?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    Thank you so much, @cloud-fan !


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80857/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SPARK-22672][SQL] Support for pushing down...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    BTW, @cloud-fan . Do you mean literally `move`? I'm wondering if I'm thinking in a different way.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #18995: [SPARK-21787][SQL] Support for pushing down filte...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/18995


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    Hi, @cloud-fan, @gatorsmile, @rxin , @sameeragarwal .
    I tested this on #18953, this only works with Apache ORC 1.4.0.
    This issue is reported saparately. And, to keep #18953 minimally, I didn't include this into that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [WIP][SPARK-21787][SQL] Support for pushing down filters...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #18995: [SPARK-21787][SQL] Support for pushing down filte...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun closed the pull request at:

    https://github.com/apache/spark/pull/18995


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    **[Test build #83700 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83700/testReport)** for PR 18995 at commit [`b31acc5`](https://github.com/apache/spark/commit/b31acc5ac5b34fcc8868252a7e3217b959c6d6d8).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [WIP][SPARK-21787][SQL] Support for pushing down filters...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    **[Test build #83700 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83700/testReport)** for PR 18995 at commit [`b31acc5`](https://github.com/apache/spark/commit/b31acc5ac5b34fcc8868252a7e3217b959c6d6d8).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18995
  
    **[Test build #84405 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84405/testReport)** for PR 18995 at commit [`9f6d75b`](https://github.com/apache/spark/commit/9f6d75bece86233baeb277c95b1974ac207c0d32).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org