You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/04 18:04:29 UTC

[GitHub] [arrow] nealrichardson commented on a change in pull request #11308: ARROW-14216: [R] Disable auto-cleaning of duckdb tables

nealrichardson commented on a change in pull request #11308:
URL: https://github.com/apache/arrow/pull/11308#discussion_r721595946



##########
File path: r/R/duckdb.R
##########
@@ -29,7 +29,7 @@
 #' @param table_name a name to use in DuckDB for this object. The default is a
 #' unique string `"arrow_"` followed by numbers.
 #' @param auto_disconnect should the table be automatically cleaned up when the
-#' resulting object is removed (and garbage collected)? Default: `TRUE`
+#' resulting object is removed (and garbage collected)? Default: `FALSE`

Review comment:
       Can you add a note explaining the consequences of cleaning up, or choosing not to clean up? As a user, I see that there is an option, but I have no idea why I would want to change the value or not.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org