You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/02 11:26:33 UTC
[GitHub] [superset] michael-s-molina commented on pull request #14932: chore: Improves the native filters UI/UX - iteration 6
michael-s-molina commented on pull request #14932:
URL: https://github.com/apache/superset/pull/14932#issuecomment-852947189
> @michael-s-molina Love those changes! 1 question - in the PR description it says `Opens the Advanced section if any of its options are checked`, but on the "after" video the advanced section is closed by default even though hierarchical filter checkbox is selected. Is that a bug or have I misunderstood the description?
> A suggestion for the next iteration - when I open the filters config modal, console gets flooded with warning messages from Antd Form (see screenshot). If it's easy to fix, it'd be great to get rid of those warning 🙂
> 
@kgabryje I added the `Opens the Advanced section if any of its options are checked` after recording the video 🤣 . I was going to add it in iteration 7 but since 6 was still opened I decided to increment it. Sorry about that.
I notice all these warnings too. I'm planning to fix this in the following optional iteration:
> Split the FiltersConfigForm into smaller components to make it easier to read
In fact, I'll change the PR description to make it more clear about that.
> Split the FiltersConfigForm into smaller components to make it easier to read and remove react warnings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org