You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Pranay Singh (Code Review)" <ge...@cloudera.org> on 2017/08/14 23:03:15 UTC
[Impala-ASF-CR] IMPALA-4861: READ WRITE warning on CREATE TABLE LIKE PARQUET.
Pranay Singh has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7671
Change subject: IMPALA-4861: READ_WRITE warning on CREATE TABLE LIKE PARQUET.
......................................................................
IMPALA-4861: READ_WRITE warning on CREATE TABLE LIKE PARQUET.
Fix: If the source URI does not have write permissions we get
a "READ WRITE warning" on CREATE TABLE LIKE PARQUET.
During analyze() in the class CreateTableLikeFileStmt we should
be checking only for "READ" permission for the source URI
not for READ and WRITE as the source URI should be readable.
Change-Id: I56799c4da482fb634ce440f8764dd44234dc22ab
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeFileStmt.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/7671/1
--
To view, visit http://gerrit.cloudera.org:8080/7671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I56799c4da482fb634ce440f8764dd44234dc22ab
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pranay Singh
[Impala-ASF-CR] IMPALA-4861: READ WRITE warning on CREATE TABLE LIKE PARQUET.
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-4861: READ_WRITE warning on CREATE TABLE LIKE PARQUET.
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56799c4da482fb634ce440f8764dd44234dc22ab
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4861: READ WRITE warning on CREATE TABLE LIKE PARQUET.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4861: READ_WRITE warning on CREATE TABLE LIKE PARQUET.
......................................................................
IMPALA-4861: READ_WRITE warning on CREATE TABLE LIKE PARQUET.
Fix: If the source URI does not have write permissions we get
a "READ WRITE warning" on CREATE TABLE LIKE PARQUET.
During analyze() in the class CreateTableLikeFileStmt we should
be checking only for "READ" permission for the source URI
not for READ and WRITE as the source URI should be readable.
Change-Id: I56799c4da482fb634ce440f8764dd44234dc22ab
Reviewed-on: http://gerrit.cloudera.org:8080/7671
Reviewed-by: Sailesh Mukil <sa...@cloudera.com>
Reviewed-by: Bharath Vissapragada <bh...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeFileStmt.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Bharath Vissapragada: Looks good to me, approved
Sailesh Mukil: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/7671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56799c4da482fb634ce440f8764dd44234dc22ab
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-4861: READ WRITE warning on CREATE TABLE LIKE PARQUET.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4861: READ_WRITE warning on CREATE TABLE LIKE PARQUET.
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1055/
--
To view, visit http://gerrit.cloudera.org:8080/7671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56799c4da482fb634ce440f8764dd44234dc22ab
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4861: READ WRITE warning on CREATE TABLE LIKE PARQUET.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4861: READ_WRITE warning on CREATE TABLE LIKE PARQUET.
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56799c4da482fb634ce440f8764dd44234dc22ab
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4861: READ WRITE warning on CREATE TABLE LIKE PARQUET.
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4861: READ_WRITE warning on CREATE TABLE LIKE PARQUET.
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56799c4da482fb634ce440f8764dd44234dc22ab
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4861: READ WRITE warning on CREATE TABLE LIKE PARQUET.
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4861: READ_WRITE warning on CREATE TABLE LIKE PARQUET.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56799c4da482fb634ce440f8764dd44234dc22ab
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No