You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/09/10 01:43:34 UTC

[GitHub] [logging-log4j2] schlosna commented on a change in pull request #573: Reduce PatternLayout branching

schlosna commented on a change in pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r705830363



##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/LevelPatternConverter.java
##########
@@ -123,7 +120,7 @@ private static String left(final Level level, final int length) {
      */
     @Override
     public void format(final LogEvent event, final StringBuilder output) {
-        output.append(levelMap == null ? event.getLevel().toString() : levelMap.get(event.getLevel()));
+

Review comment:
       Is this supposed to be empty, or should this method be removed and handled by super?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org