[GitHub] markusthoemmes commented on a change in pull request #3343: Support time-series DB using Kamon Tag, and optional granular metric.

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #3343: Support time-series DB using Kamon Tag, and optional granular metric.
URL: https://github.com/apache/incubator-openwhisk/pull/3343#discussion_r170419789
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/common/Logging.scala
 ##########
 @@ -164,27 +164,44 @@ private object Logging {
     if (simpleName.endsWith("$")) simpleName.dropRight(1)
     else simpleName
   }
-
 }
 
 private object Emitter {
   val timeFormat = DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'").withZone(ZoneId.of("UTC"))
 }
 
-case class LogMarkerToken(component: String, action: String, state: String) {
+case class LogMarkerToken(component: String, action: String, state: String, tags: Option[Map[String, String]] = None) {
+
   override def toString() = component + "_" + action + "_" + state
 
   def asFinish = copy(state = LoggingMarkers.finish)
   def asError = copy(state = LoggingMarkers.error)
 }
 
 object LogMarkerToken {
+
+  def apply(component: String, action: String, state: String, tags: Map[String, String]): LogMarkerToken = {
+    if (!TransactionId.metricsKamonTags) {
 
 Review comment:
   Should this be handled by the `LogMarkerToken`'s `toString`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services