[GitHub] [maven-jar-plugin] jorsol commented on a diff in pull request #19: [MJAR-278] Update plugin (requires Maven 3.2.5+)

[GitBox <gi...@apache.org>]

jorsol commented on code in PR #19:
URL: https://github.com/apache/maven-jar-plugin/pull/19#discussion_r900202520


##########
pom.xml:
##########
@@ -25,8 +25,7 @@
   <parent>
     <artifactId>maven-plugins</artifactId>
     <groupId>org.apache.maven.plugins</groupId>
-    <version>34</version>
-    <relativePath>../../pom/maven/maven-plugins/pom.xml</relativePath>
+    <version>35</version>

Review Comment:
   36
   
   Unrelated, but the groupId should come first.



##########
pom.xml:
##########
@@ -130,7 +132,11 @@
       <groupId>org.apache.maven.shared</groupId>
       <artifactId>maven-shared-utils</artifactId>
       <version>3.3.4</version>
-      <scope>runtime</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.codehaus.plexus</groupId>
+      <artifactId>plexus-archiver</artifactId>
+      <version>4.2.5</version>

Review Comment:
   This should not be needed when the maven-archiver 3.6.0 is released that will update plexus-archiver to 4.3.0, so the explicit dependency should not be added.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org