You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/10/17 23:29:59 UTC

[GitHub] [tvm] zxybazh opened a new pull request, #13112: [PopenPool] Enable Stdout & Stderr Redirect in PopenPool & PopenWorker

zxybazh opened a new pull request, #13112:
URL: https://github.com/apache/tvm/pull/13112

   This PR enables redirection of the standard output stream and standard error stream to given subprocess handler.
   
   This function especially improves the usage of `LocalRunner` because previously a sample candidate's exception during running could print long lines of output, making console logging / notebook logging obsolete. In the meantime, any failure of the candidates are still preserved in the per-task logging results (Schedule, trace & TIR available, doesn't include the stack trace though).
   
   Credits to @Hzfengsy's fix in https://github.com/mlc-ai/relax/pull/6.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] junrushao merged pull request #13112: [PopenPool] Enable Stdout & Stderr Redirect in PopenPool & PopenWorker

Posted by GitBox <gi...@apache.org>.
junrushao merged PR #13112:
URL: https://github.com/apache/tvm/pull/13112


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] zxybazh commented on pull request #13112: [PopenPool] Enable Stdout & Stderr Redirect in PopenPool & PopenWorker

Posted by GitBox <gi...@apache.org>.
zxybazh commented on PR #13112:
URL: https://github.com/apache/tvm/pull/13112#issuecomment-1281790795

   > LGTM, but I wonder if we can have additional testcases
   
   Thanks, will add that in a follow up PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] zxybazh commented on pull request #13112: [PopenPool] Enable Stdout & Stderr Redirect in PopenPool & PopenWorker

Posted by GitBox <gi...@apache.org>.
zxybazh commented on PR #13112:
URL: https://github.com/apache/tvm/pull/13112#issuecomment-1281628524

   CC @Hzfengsy @shingjan  @junrushao @tqchen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tvm-bot commented on pull request #13112: [PopenPool] Enable Stdout & Stderr Redirect in PopenPool & PopenWorker

Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13112:
URL: https://github.com/apache/tvm/pull/13112#issuecomment-1281627254

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org