You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/05/23 11:00:22 UTC

[GitHub] [ozone] JacksonYao287 commented on a diff in pull request #3445: HDDS-6771. EC: ReplicationManager - make ContainerReplicaPendingOps into a SCM service

JacksonYao287 commented on code in PR #3445:
URL: https://github.com/apache/ozone/pull/3445#discussion_r879319891


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ContainerReplicaPendingOps.java:
##########
@@ -48,10 +50,19 @@ public class ContainerReplicaPendingOps {
       pendingOps = new ConcurrentHashMap<>();
   private final Striped<ReadWriteLock> stripedLock = Striped.readWriteLock(64);
 
-  public ContainerReplicaPendingOps(final ConfigurationSource conf,
-      Clock clock) {
+  private final ExpiredContainerReplicaOpScrubber
+      expiredContainerReplicaOpScrubber;
+
+  public ContainerReplicaPendingOps(
+      final ConfigurationSource conf,
+      final Clock clock,
+      final SCMServiceManager serviceManager,
+      final SCMContext scmContext) {

Review Comment:
   thanks for the suggestion, looks good.  will do it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org