[jira] Updated: (SOLR-924) Solr: Making finalizers call super.finalize() wrapped in try..finally block

["Kay Kay (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kay Kay updated SOLR-924:
-------------------------

    Attachment: SOLR-924.patch

The following classes have their try .. finally clause implemented in finalizers set up for recursive call. 

Index: contrib/dataimporthandler/src/main/java/org/apache/solr/handler/dataimport/JdbcDataSource.java
Index: src/java/org/apache/solr/update/SolrIndexWriter.java
Index: src/java/org/apache/solr/core/SolrCore.java
Index: src/java/org/apache/solr/core/CoreContainer.java
Index: src/common/org/apache/solr/common/util/ConcurrentLRUCache.java


> Solr: Making finalizers call super.finalize() wrapped in try..finally block 
> ----------------------------------------------------------------------------
>
>                 Key: SOLR-924
>                 URL: https://issues.apache.org/jira/browse/SOLR-924
>             Project: Solr
>          Issue Type: Improvement
>         Environment: Tomcat 6, JRE 6
>            Reporter: Kay Kay
>         Attachments: SOLR-924.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> There are some occurences of finalizers in the code base. While the presence of them is debatable and discussed in a separate JIRA - the ones that are retained are better off wrapped around a try .. finally block to recursively call the finalizer of the super class for proper resource usage unwinding , (in case finalizers get invoked ). 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.