You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/05/17 22:27:17 UTC

[GitHub] [incubator-iceberg] jun-he opened a new pull request #1045: Fix partition spec and transforms in python

jun-he opened a new pull request #1045:
URL: https://github.com/apache/incubator-iceberg/pull/1045


   This PR fixed a few bugs/issues in partition spec and transforms classes
    - In partition spec `source_column.types` should be `source_column.type`
    - `type_id` is missed or is mistakenly used as `type_id()` in multiple classes
    - In dates class, `__str__` will cause `RecursionError` as it calls itself.
    - Fixed returning `TruncateLong` instead of `TruncateInteger` for `TypeID.LONG`.
    - Fixed truncate static method to use the right input parameter `type_var`.
    - added unit tests in python, similar to Java partition spec base test.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [incubator-iceberg] rdblue commented on pull request #1045: Fix partition spec and transforms in python

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1045:
URL: https://github.com/apache/incubator-iceberg/pull/1045#issuecomment-630422922


   Thanks, @jun-he! Looks good to me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [incubator-iceberg] rdblue merged pull request #1045: Fix partition spec and transforms in python

Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1045:
URL: https://github.com/apache/incubator-iceberg/pull/1045


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org