You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/06/10 19:19:33 UTC
Review Request: Fix for CLOUDSTACK-1622, CLOUDSTACK-1704
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11780/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
Description
-------
Global parameter "cluster.memory.allocated.capacity.disablethreshold" and "cluster.cpu.allocated.capacity.disablethreshold" are not disabling cluster after threshold values.
This is due to unhandled sql query when these parameters have null values in the DB. Fixed by adding that case in the query.
This addresses bugs CLOUDSTACK-1622 and CLOUDSTACK-1704.
Diffs
-----
engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java 0b9ff1a
Diff: https://reviews.apache.org/r/11780/diff/
Testing
-------
Tested locally
Thanks,
Harikrishna Patnala
Re: Review Request: Fix for CLOUDSTACK-1622, CLOUDSTACK-1704
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11780/#review21787
-----------------------------------------------------------
Commit a30f9fa64a49acfe7d3ac57f2ef9d890473f48c4 in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a30f9fa ]
Fix for CLOUDSTACK-1704 and CLOUDSTACK-1622
Signed-off-by: Abhinandan Prateek <ap...@apache.org>
- ASF Subversion and Git Services
On June 10, 2013, 5:19 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11780/
> -----------------------------------------------------------
>
> (Updated June 10, 2013, 5:19 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Description
> -------
>
> Global parameter "cluster.memory.allocated.capacity.disablethreshold" and "cluster.cpu.allocated.capacity.disablethreshold" are not disabling cluster after threshold values.
>
> This is due to unhandled sql query when these parameters have null values in the DB. Fixed by adding that case in the query.
>
>
> This addresses bugs CLOUDSTACK-1622 and CLOUDSTACK-1704.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java 0b9ff1a
>
> Diff: https://reviews.apache.org/r/11780/diff/
>
>
> Testing
> -------
>
> Tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: Fix for CLOUDSTACK-1622, CLOUDSTACK-1704
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11780/#review21785
-----------------------------------------------------------
Ship it!
Ship It!
- Abhinandan Prateek
On June 10, 2013, 5:19 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11780/
> -----------------------------------------------------------
>
> (Updated June 10, 2013, 5:19 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Description
> -------
>
> Global parameter "cluster.memory.allocated.capacity.disablethreshold" and "cluster.cpu.allocated.capacity.disablethreshold" are not disabling cluster after threshold values.
>
> This is due to unhandled sql query when these parameters have null values in the DB. Fixed by adding that case in the query.
>
>
> This addresses bugs CLOUDSTACK-1622 and CLOUDSTACK-1704.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java 0b9ff1a
>
> Diff: https://reviews.apache.org/r/11780/diff/
>
>
> Testing
> -------
>
> Tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: Fix for CLOUDSTACK-1622, CLOUDSTACK-1704
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11780/#review21786
-----------------------------------------------------------
Commit a30f9fa64a49acfe7d3ac57f2ef9d890473f48c4 in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a30f9fa ]
Fix for CLOUDSTACK-1704 and CLOUDSTACK-1622
Signed-off-by: Abhinandan Prateek <ap...@apache.org>
- ASF Subversion and Git Services
On June 10, 2013, 5:19 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11780/
> -----------------------------------------------------------
>
> (Updated June 10, 2013, 5:19 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Description
> -------
>
> Global parameter "cluster.memory.allocated.capacity.disablethreshold" and "cluster.cpu.allocated.capacity.disablethreshold" are not disabling cluster after threshold values.
>
> This is due to unhandled sql query when these parameters have null values in the DB. Fixed by adding that case in the query.
>
>
> This addresses bugs CLOUDSTACK-1622 and CLOUDSTACK-1704.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java 0b9ff1a
>
> Diff: https://reviews.apache.org/r/11780/diff/
>
>
> Testing
> -------
>
> Tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>