You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by "lujiajing1126 (via GitHub)" <gi...@apache.org> on 2023/03/03 03:52:27 UTC

[GitHub] [skywalking-java] lujiajing1126 commented on pull request #466: fix tomcat-10x-plugin and add test case to support tomcat7.x-8.x-9.x

lujiajing1126 commented on PR #466:
URL: https://github.com/apache/skywalking-java/pull/466#issuecomment-1452922949

   > Somehow Spring 6 case fails? Could you recheck?
   
   The only issue I could find is that we expected `POST:/create` call returns status code 200, but in the actual data is 201.
   
   But I don't think this PR is relevant since for `EntrySpan`, the tag is set when `stackDepth == currentMaxDepth`. This means only the Spring plugin can set tags.
   
   @kezhenxu94 @wu-sheng any idea?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org