You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/06 07:03:01 UTC
[GitHub] [incubator-nuttx-apps] GUIDINGLI opened a new pull request #801: Update Application.mk
GUIDINGLI opened a new pull request #801:
URL: https://github.com/apache/incubator-nuttx-apps/pull/801
## Summary
Update Application.mk
1. Generate c source code dependence with c compiler and flags, It's wrong to invoke the c++ compiler with c++ flags
2. Fix https://github.com/apache/incubator-nuttx-apps/pull/795 caused depends error.
wrong: file.c => file.dir.o
right: file.c => file.c.dir.o
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] yamt commented on pull request #801: Update Application.mk
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #801:
URL: https://github.com/apache/incubator-nuttx-apps/pull/801#issuecomment-874640632
> > i still want this reverted unless a convincing use case for this unusual setup is provided.
>
> There are projects which have source files only different with suffix.
> Here is one(NE10_fft_float32.neon.c/NE10_fft_float32.neon.s):
> https://github.com/projectNe10/Ne10/tree/master/modules/dsp
> This happen frequently in the algorithm library(like Ne10: c v.s. neon). We need provide a soluton to support the type of project.
ok.
it seems like what cmake does by default. i was not aware of the convention. thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #801: Update Application.mk
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #801:
URL: https://github.com/apache/incubator-nuttx-apps/pull/801#issuecomment-874562134
> i still want this reverted unless a convincing use case for this unusual setup is provided.
There are projects which have source files only different with suffix.
Here is one(NE10_fft_float32.neon.c/NE10_fft_float32.neon.s):
https://github.com/projectNe10/Ne10/tree/master/modules/dsp
This happen frequently in the algorithm library(like Ne10: c v.s. neon). We need provide a soluton to support the type of project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #801: Update Application.mk
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #801:
URL: https://github.com/apache/incubator-nuttx-apps/pull/801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #801: Update Application.mk
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #801:
URL: https://github.com/apache/incubator-nuttx-apps/pull/801#issuecomment-874562134
> i still want this reverted unless a convincing use case for this unusual setup is provided.
There are projects which have source files only different with suffix.
Here is one(NE10_fft_float32.neon.c/NE10_fft_float32.neon.s):
https://github.com/projectNe10/Ne10/tree/master/modules/dsp
This happen frequently in the algorithm library(like Ne10). We need provide a soluton to support the type of project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #801: Update Application.mk
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #801:
URL: https://github.com/apache/incubator-nuttx-apps/pull/801#issuecomment-874562134
> i still want this reverted unless a convincing use case for this unusual setup is provided.
There are projects which have source files only different with suffix.
Here is one(NE10_fft_float32.neon.c/NE10_fft_float32.neon.s):
https://github.com/projectNe10/Ne10/tree/master/modules/dsp
This happen frequently in the algorithm library(like Ne10). We need provide a soluton to support the type of project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #801: Update Application.mk
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #801:
URL: https://github.com/apache/incubator-nuttx-apps/pull/801#issuecomment-874562134
> i still want this reverted unless a convincing use case for this unusual setup is provided.
There are projects which have source files only different with suffix.
Here is one(NE10_fft_float32.neon.c/NE10_fft_float32.neon.s):
https://github.com/projectNe10/Ne10/tree/master/modules/dsp
This happen frequently in the algorithm library(like Ne10: c v.s. neon). We need provide a soluton to support the type of project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] yamt commented on pull request #801: Update Application.mk
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #801:
URL: https://github.com/apache/incubator-nuttx-apps/pull/801#issuecomment-874640632
> > i still want this reverted unless a convincing use case for this unusual setup is provided.
>
> There are projects which have source files only different with suffix.
> Here is one(NE10_fft_float32.neon.c/NE10_fft_float32.neon.s):
> https://github.com/projectNe10/Ne10/tree/master/modules/dsp
> This happen frequently in the algorithm library(like Ne10: c v.s. neon). We need provide a soluton to support the type of project.
ok.
it seems like what cmake does by default. i was not aware of the convention. thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org