[GitHub] [beam] lukecwik commented on a diff in pull request #24295: Add warning about google-cloud-platform-core dependency change in #24235

[GitBox <gi...@apache.org>]

lukecwik commented on code in PR #24295:
URL: https://github.com/apache/beam/pull/24295#discussion_r1028378251


##########
CHANGES.md:
##########
@@ -74,6 +74,10 @@
 
 * `ParquetIO.withSplit` was removed since splittable reading has been the default behavior since 2.35.0. The effect of
   this change is to drop support for non-splittable reading (Java)([#23832](https://github.com/apache/beam/issues/23832)).
+* `beam-sdks-java-extensions-google-cloud-platform-core` is no longer a
+  dependency of the Beam Portable SDK Harness. Some users of the portable runner
+  may have an undeclared dependency on this package, for example using gcs with
+  TextIO, and will now need to declare the dependency.

Review Comment:
   ```suggestion
     may have an undeclared dependency on this package (for example using GCS with
     TextIO) and will now need to declare the dependency.
   ```



##########
CHANGES.md:
##########
@@ -74,6 +74,10 @@
 
 * `ParquetIO.withSplit` was removed since splittable reading has been the default behavior since 2.35.0. The effect of
   this change is to drop support for non-splittable reading (Java)([#23832](https://github.com/apache/beam/issues/23832)).
+* `beam-sdks-java-extensions-google-cloud-platform-core` is no longer a
+  dependency of the Beam Portable SDK Harness. Some users of the portable runner

Review Comment:
   ```suggestion
     dependency of the Java SDK Harness. Some users of a portable runner
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org