You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/29 11:17:13 UTC
[GitHub] [doris] HappenLee commented on a diff in pull request #15440: [fix](hashjoin) Fix right join pull output block memory overflow
HappenLee commented on code in PR #15440:
URL: https://github.com/apache/doris/pull/15440#discussion_r1058893537
##########
be/src/vec/exec/join/join_op.h:
##########
@@ -202,6 +206,7 @@ struct RowRefListWithFlag : RowRef {
friend class ForwardIterator<RowRefListWithFlag>;
Batch<RowRefType>* next = nullptr;
+ ForwardIterator<RowRefListWithFlag> _visited_iter;
Review Comment:
the way will cause unnecessary mem and performance problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org