You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "jdesjean (via GitHub)" <gi...@apache.org> on 2023/09/13 21:18:53 UTC

[GitHub] [spark] jdesjean commented on pull request #42910: [SPARK-45133][CONNECT][TESTS][FOLLOWUP] Add test that queries transition to FINISHED

jdesjean commented on PR #42910:
URL: https://github.com/apache/spark/pull/42910#issuecomment-1718330877

   It be great if we could improve [SparkConnectServiceSuite](https://src.dev.databricks.com/databricks/runtime/-/blob/connector/connect/server/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectServiceSuite.scala?L247) instead of creating a new one. However, it seems difficult because executePlan is blocking. Logic lgtm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org