You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by mc...@apache.org on 2008/03/20 12:57:50 UTC
svn commit: r639255 - in
/incubator/tuscany/java/sca/modules/binding-ws-axis2/src:
main/java/org/apache/tuscany/sca/binding/ws/axis2/
test/java/org/apache/tuscany/sca/binding/ws/axis2/itests/
test/java/org/apache/tuscany/sca/binding/ws/axis2/itests/soa...
Author: mcombellack
Date: Thu Mar 20 04:57:48 2008
New Revision: 639255
URL: http://svn.apache.org/viewvc?rev=639255&view=rev
Log:
Minor JavaDoc updates and spelling corrections
Modified:
incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2BindingInvoker.java
incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ReferenceBindingProvider.java
incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ServiceBindingProvider.java
incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ServiceClient.java
incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ServiceProvider.java
incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ServiceServlet.java
incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/TuscanyAxisConfigurator.java
incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/TuscanyListingAgent.java
incubator/tuscany/java/sca/modules/binding-ws-axis2/src/test/java/org/apache/tuscany/sca/binding/ws/axis2/itests/QuestionMarkWSDLTestCase.java
incubator/tuscany/java/sca/modules/binding-ws-axis2/src/test/java/org/apache/tuscany/sca/binding/ws/axis2/itests/soap12/QuestionMarkWSDLTestCase.java
Modified: incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2BindingInvoker.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2BindingInvoker.java?rev=639255&r1=639254&r2=639255&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2BindingInvoker.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2BindingInvoker.java Thu Mar 20 04:57:48 2008
@@ -121,7 +121,7 @@
OMElement response = responseMC.getEnvelope().getBody().getFirstElement();
- // FIXME: [rfeng] We have to pay performance penality to build the complete OM as the operationClient.complete() will
+ // FIXME: [rfeng] We have to pay performance penalty to build the complete OM as the operationClient.complete() will
// release the underlying HTTP connection.
// Force the response to be populated, see https://issues.apache.org/jira/browse/TUSCANY-1541
if (response != null) {
Modified: incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ReferenceBindingProvider.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ReferenceBindingProvider.java?rev=639255&r1=639254&r2=639255&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ReferenceBindingProvider.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ReferenceBindingProvider.java Thu Mar 20 04:57:48 2008
@@ -60,7 +60,7 @@
// TODO - fix up the conversational flag and operation sequences in case the contract has come from WSDL
// as we don't yet support requires="conversational" or sca:endConversation annotations
- // in WSDL interface descriptions (see section 1.5.4 of the assembly spec V1.0)
+ // in WSDL interface descriptions (see section 1.5.4 of the Assembly Specification V1.0)
if ( reference.getInterfaceContract().getInterface() != null ) {
contract.getInterface().setConversational(reference.getInterfaceContract().getInterface().isConversational());
Modified: incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ServiceBindingProvider.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ServiceBindingProvider.java?rev=639255&r1=639254&r2=639255&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ServiceBindingProvider.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ServiceBindingProvider.java Thu Mar 20 04:57:48 2008
@@ -63,7 +63,7 @@
// TODO - fix up the conversational flag and operation sequences in case the contract has come from WSDL
// as we don't yet support requires="conversational" or sca:endConversation annotations
- // in WSDL interface descriptions (see section 1.5.4 of the assembly spec V1.0)
+ // in WSDL interface descriptions (see section 1.5.4 of the Assembly Specification V1.0)
if (service.getInterfaceContract().getInterface() != null ) {
contract.getInterface().setConversational(service.getInterfaceContract().getInterface().isConversational());
Modified: incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ServiceClient.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ServiceClient.java?rev=639255&r1=639254&r2=639255&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ServiceClient.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ServiceClient.java Thu Mar 20 04:57:48 2008
@@ -176,7 +176,7 @@
}
/**
- * URI resolver implementation for xml schema
+ * URI resolver implementation for XML schema
*/
public static class URIResolverImpl implements URIResolver {
private Definition definition;
@@ -288,7 +288,7 @@
// only contains a portType and not a service and port. Synthesize a
// service and port using WSDL4J and add them to the wsdlDefinition to
// keep Axis happy.
- //FIXME: it would be better to do this for all WSDLs to explictly control the
+ //FIXME: it would be better to do this for all WSDLs to explicitly control the
// service and port that Axis will use, rather than just hoping the user has
// placed a suitable service and/or port first in the WSDL.
WSDLDefinitionHelper helper = new WSDLDefinitionHelper();
Modified: incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ServiceProvider.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ServiceProvider.java?rev=639255&r1=639254&r2=639255&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ServiceProvider.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ServiceProvider.java Thu Mar 20 04:57:48 2008
@@ -175,8 +175,8 @@
uri = "jms:" + uri;
}
- // construct the rest of the uri based on the policy. All the details are put
- // into the uri here rather than being place directly into the Axis configuration
+ // construct the rest of the URI based on the policy. All the details are put
+ // into the URI here rather than being place directly into the Axis configuration
// as the Axis JMS sender relies on parsing the target URI
Axis2ConfigParamPolicy axis2ConfigParamPolicy = null;
for ( Object policy : transportJmsPolicySet.getPolicies() ) {
@@ -227,7 +227,7 @@
public void start() {
- // TODO: if <binding.ws> specifies the wsdl service then should create a
+ // TODO: if <binding.ws> specifies the WSDL service then should create a
// service for every port
try {
@@ -252,7 +252,7 @@
ListenerManager listenerManager = configContext.getListenerManager();
TransportInDescription trsIn = configContext.getAxisConfiguration().getTransportIn(Constants.TRANSPORT_JMS);
- // get JMS transport parameters from the binding uri
+ // get JMS transport parameters from the binding URI
Map<String, String> jmsProps = JMSUtils.getProperties( wsBinding.getURI() );
// collect the parameters used to configure the JMS transport
@@ -328,14 +328,14 @@
}
/**
- * Compute the endpoint URI based on section 2.1.1 of the WS binding spec 1.
+ * Compute the endpoint URI based on section 2.1.1 of the WS binding Specification 1.
* The URIs in the endpoint(s) of the referenced WSDL, which may be relative
* 2. The URI specified by the wsa:Address element of the
* wsa:EndpointReference, which may be relative 3. The explicitly stated URI
* in the "uri" attribute of the binding.ws element, which may be relative,
- * 4. The implicit URI as defined by in section 1.7 in the SCA Assembly spec
+ * 4. The implicit URI as defined by in section 1.7 in the SCA Assembly Specification
* If the <binding.ws> has no wsdlElement but does have a uri attribute then
- * the uri takes precidence over any implicitly used WSDL.
+ * the uri takes precedence over any implicitly used WSDL.
*
*/
protected String computeActualURI(RuntimeComponent component, AbstractContract contract) {
@@ -351,11 +351,11 @@
URI wsdlURI = null;
if (wsBinding.getServiceName() != null && wsBinding.getBindingName() == null) {
- // <binding.ws> explicitly points at a wsdl port, may be a relative URI
+ // <binding.ws> explicitly points at a WSDL port, may be a relative URI
wsdlURI = getEndpoint(wsBinding.getPort());
}
- // if the wsdl port/endpoint has an absolute URI use that
+ // if the WSDL port/endpoint has an absolute URI use that
if (wsdlURI != null && wsdlURI.isAbsolute()) {
return wsdlURI.toString();
}
@@ -365,7 +365,7 @@
return eprURI.toString();
}
- // either there is no wsdl port endpoint URI or that URI is relative
+ // either there is no WSDL port endpoint URI or that URI is relative
String actualURI = wsBinding.getURI();
if (eprURI != null && eprURI.toString().length() != 0) {
// there is a relative URI in the binding EPR
@@ -373,7 +373,7 @@
}
if (wsdlURI != null && wsdlURI.toString().length() != 0) {
- // there is a relative URI in the wsdl port
+ // there is a relative URI in the WSDL port
actualURI = actualURI + "/" + wsdlURI;
}
Modified: incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ServiceServlet.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ServiceServlet.java?rev=639255&r1=639254&r2=639255&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ServiceServlet.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/Axis2ServiceServlet.java Thu Mar 20 04:57:48 2008
@@ -45,7 +45,7 @@
import org.apache.axis2.transport.http.server.HttpUtils;
/**
- * This overrides the servlet init of the AxisServlet so Tuscany can use
+ * This overrides the Servlet init of the AxisServlet so Tuscany can use
* a single Axis2 ConfigurationContext instance shared between AxisServlet
* instances for each SCA service with a ws binding.
* TODO: need to review if thats really what we want to be doing
@@ -71,7 +71,7 @@
}
/**
- * Override Axis2 servlet method to avoid loop when init
+ * Override Axis2 Servlet method to avoid loop when init
* is called after servletConfig already initialized by
* this classes init(ConfigurationContext) method.
*/
@@ -121,7 +121,7 @@
return null;
}
- @SuppressWarnings("unused") // it's on the servlet 2.5 api so we need it
+ @SuppressWarnings("unused") // it's on the Servlet 2.5 API so we need it
public String getContextPath() {
return null;
}
@@ -261,7 +261,7 @@
/**
/**
- * Override the AxisServlet method so as to not add "/services" into the url
+ * Override the AxisServlet method so as to not add "/services" into the URL
* and to work with Tuscany service names. can go once moved to Axis2 1.3
*/
@Override
Modified: incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/TuscanyAxisConfigurator.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/TuscanyAxisConfigurator.java?rev=639255&r1=639254&r2=639255&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/TuscanyAxisConfigurator.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/TuscanyAxisConfigurator.java Thu Mar 20 04:57:48 2008
@@ -46,10 +46,10 @@
*/
public class TuscanyAxisConfigurator extends URLBasedAxisConfigurator implements AxisConfigurator {
- /* these two fields are part of a temporary fix to solve problems that maven has with including
+ /* these two fields are part of a temporary fix to solve problems that Maven has with including
* rampart-1.3.mar into the classpath and also at the time of Release 1.0 rampart-1.3.mar seems
* to pull in a SNAPSHOT version of rampart-project pom. Hence rampart.mar has been excluded
- * as a maven dependency and has been packed with this module
+ * as a Maven dependency and has been packed with this module
*/
/************start of fix *********************************************************************/
private URL axis2_xml =
@@ -73,10 +73,10 @@
return configContext;
}
- /* these three methods are part of a temporary fix to solve problems that maven has with including
+ /* these three methods are part of a temporary fix to solve problems that Maven has with including
* rampart-1.3.mar into the classpath and also at the time of Release 1.0 rampart-1.3.mar seems
* to pull in a SNAPSHOT version of rampart-project pom. Hence rampart.mar has been excluded
- * as a maven dependency and has been packed with this module
+ * as a Maven dependency and has been packed with this module
*/
/************start of fix *********************************************************************/
public AxisConfiguration getAxisConfiguration() throws AxisFault {
Modified: incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/TuscanyListingAgent.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/TuscanyListingAgent.java?rev=639255&r1=639254&r2=639255&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/TuscanyListingAgent.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ws-axis2/src/main/java/org/apache/tuscany/sca/binding/ws/axis2/TuscanyListingAgent.java Thu Mar 20 04:57:48 2008
@@ -61,7 +61,7 @@
/**
* A Tuscany specific Axis2 ListingAgent as the Axis2 one does not work
- * with the Tuscany sevice names which include slash ('/') characters.
+ * with the Tuscany service names which include slash ('/') characters.
* Unfortunately it ends up having to copy a fair amount of Axis2 code to do this.
*/
public class TuscanyListingAgent extends ListingAgent {
Modified: incubator/tuscany/java/sca/modules/binding-ws-axis2/src/test/java/org/apache/tuscany/sca/binding/ws/axis2/itests/QuestionMarkWSDLTestCase.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ws-axis2/src/test/java/org/apache/tuscany/sca/binding/ws/axis2/itests/QuestionMarkWSDLTestCase.java?rev=639255&r1=639254&r2=639255&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ws-axis2/src/test/java/org/apache/tuscany/sca/binding/ws/axis2/itests/QuestionMarkWSDLTestCase.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ws-axis2/src/test/java/org/apache/tuscany/sca/binding/ws/axis2/itests/QuestionMarkWSDLTestCase.java Thu Mar 20 04:57:48 2008
@@ -35,7 +35,7 @@
import org.apache.tuscany.sca.host.embedded.SCADomain;
/**
- * Test ?wsdl works and that the returned wsdl has the correct endpoint
+ * Test ?wsdl works and that the returned WSDL has the correct endpoint
*/
public class QuestionMarkWSDLTestCase extends TestCase {
Modified: incubator/tuscany/java/sca/modules/binding-ws-axis2/src/test/java/org/apache/tuscany/sca/binding/ws/axis2/itests/soap12/QuestionMarkWSDLTestCase.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-ws-axis2/src/test/java/org/apache/tuscany/sca/binding/ws/axis2/itests/soap12/QuestionMarkWSDLTestCase.java?rev=639255&r1=639254&r2=639255&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-ws-axis2/src/test/java/org/apache/tuscany/sca/binding/ws/axis2/itests/soap12/QuestionMarkWSDLTestCase.java (original)
+++ incubator/tuscany/java/sca/modules/binding-ws-axis2/src/test/java/org/apache/tuscany/sca/binding/ws/axis2/itests/soap12/QuestionMarkWSDLTestCase.java Thu Mar 20 04:57:48 2008
@@ -36,7 +36,7 @@
import org.apache.tuscany.sca.host.embedded.SCADomain;
/**
- * Test ?wsdl works and that the returned wsdl has the correct endpoint
+ * Test ?wsdl works and that the returned WSDL has the correct endpoint
*/
public class QuestionMarkWSDLTestCase extends TestCase {
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-commits-help@ws.apache.org