[GitHub] [sling-org-apache-sling-api] ghenzler edited a comment on pull request #24: SLING-9777 Better handling for invalid URIs when using SlingUri (special characters, spaces)

[GitBox <gi...@apache.org>]

ghenzler edited a comment on pull request #24:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/24#issuecomment-701587558


    In theory this PR should slightly improve test coverage, however it shows `71.4% Coverage on New Code (is less than 80%)` in https://github.com/apache/sling-org-apache-sling-api/pull/24/checks shows 
   
   The last PR does not seem to have measured this yet: https://github.com/apache/sling-org-apache-sling-api/pull/23/checks
   
   @rombert @raducotescu is this connected to the recent changes around SonarQube? 
   
   **Edit**:  So the root cause was that the measurement is taken `on New Code` - even though test coverage generally is good the new code in src was't many lines but those weren't covered with the full 80%


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org