You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "kirklund (GitHub)" <gi...@apache.org> on 2018/12/18 18:00:54 UTC

[GitHub] [geode] kirklund opened pull request #3016: GEODE-6176: Make FunctionService testable with internal delegates

Introduce new internal FunctionExecutionService API interfaces:
* FunctionExecutionService
* InternalFunctionExecutionService

Implement interfaces with:
* InternalFunctionExecutionServiceImpl

Collapse FunctionServiceManager into InternalFunctionExecutionServiceImpl

Change the two static API classes to delegate to an instance of
InternalFunctionExecutionServiceImpl:
* FunctionService (User API) -- only has private internal changes
* InternalFunctionService -- now extends FunctionService

Geode classes that use the static API classes directly can now be
changed to depend on one of the two interfaces using constructor
injection to facilitate unit testing without PowerMock.

[ Full content available at: https://github.com/apache/geode/pull/3016 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #3016: GEODE-6176: Make FunctionService testable with internal delegates

Posted by "kirklund (GitHub)" <gi...@apache.org>.
I have a 2nd PR after this one which removes PowerMock from some unit tests which were using PowerMock to override behavior in static FunctionService methods.

[ Full content available at: https://github.com/apache/geode/pull/3016 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund closed pull request #3016: GEODE-6176: Make FunctionService testable with internal delegates

Posted by "kirklund (GitHub)" <gi...@apache.org>.
[ pull request closed by kirklund ]

[ Full content available at: https://github.com/apache/geode/pull/3016 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #3016: GEODE-6176: Make FunctionService testable with internal delegates

Posted by "kirklund (GitHub)" <gi...@apache.org>.
The IntegrationTestOpenJDK8 failure is an unrelated flaky test (LocatorLauncherRemoteFileIntegrationTest)

[ Full content available at: https://github.com/apache/geode/pull/3016 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org