[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #7061: Change controller API to allow use specify column filter when query segment metadata

[GitBox <gi...@apache.org>]

siddharthteotia commented on a change in pull request #7061:
URL: https://github.com/apache/incubator-pinot/pull/7061#discussion_r652253212



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java
##########
@@ -591,7 +592,8 @@ private void deleteSegmentsInternal(String tableNameWithType, List<String> segme
   @ApiOperation(value = "Get the server metadata for all table segments", notes = "Get the server metadata for all table segments")
   public String getServerMetadata(
       @ApiParam(value = "Name of the table", required = true) @PathParam("tableName") String tableName,
-      @ApiParam(value = "OFFLINE|REALTIME") @QueryParam("type") String tableTypeStr) {
+      @ApiParam(value = "OFFLINE|REALTIME") @QueryParam("type") String tableTypeStr,

Review comment:
       (nit) please add javadocs also indicating how the column list is used and what is the behavior when user doesn't specify it (leaves it to default)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org