[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

[GitBox <gi...@apache.org>]

weizhouapache commented on code in PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#discussion_r855162285


##########
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/SnapshotObject.java:
##########
@@ -127,7 +127,7 @@ public SnapshotInfo getChild() {
         if (vo == null) {
             return null;
         }
-        return snapshotFactory.getSnapshot(vo.getId(), store);
+        return snapshotFactory.getSnapshot(vo.getSnapshotId(), store);

Review Comment:
   @Pearl1594 
   this looks like a critical issue



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org