You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/12/03 22:05:41 UTC

[GitHub] [beam] benWize commented on a change in pull request #15890: [BEAM-11936] Fix errorprone warnings

benWize commented on a change in pull request #15890:
URL: https://github.com/apache/beam/pull/15890#discussion_r762313936



##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/splittabledofn/GrowableOffsetRangeTrackerTest.java
##########
@@ -183,7 +183,7 @@ public void testProgressAfterFinished() throws Exception {
     tracker.checkDone();
     simpleEstimator.setEstimateRangeEnd(0L);
     Progress currentProgress = tracker.getProgress();
-    assertEquals(Long.MAX_VALUE - 10L, currentProgress.getWorkCompleted(), 0.001);
+    assertEquals(Long.MAX_VALUE - 10L, currentProgress.getWorkCompleted(), 0);

Review comment:
       When I remove delta here, the assertion fails with: `Use assertEquals(expected, actual, delta) to compare floating-point numbers`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org