[GitHub] [airflow] RosterIn commented on a change in pull request #14028: Reuse private_key_passphrase from SSHHook super class

[GitBox <gi...@apache.org>]

RosterIn commented on a change in pull request #14028:
URL: https://github.com/apache/airflow/pull/14028#discussion_r569793682



##########
File path: UPDATING.md
##########
@@ -84,6 +84,20 @@ constantly.
 From Airflow 2.0.0, the scheduling decisions have been moved from
 DagFileProcessor to Scheduler, so we can keep the default a bit higher: `30`.
 
+### SFTP connection `private_key_pass` extra param is renamed to `private_key_passphrase`
+
+Some operators perform SFTP operations by the means of `SFTPHook`. `SFTPHook` delegates the actual SFTP connection to
+ the `pysftp` module.
+
+When connecting with a private key protected by a passphrase, the `private_key_pass` extra parameter had to be
+ specified in the connection, and this corresponds to the arguments' naming in `pysftp`.
+
+However, `SFTPHook` inherits from `SSHHook` which already manages a `private_key_passphrase` extra param. But this
+ param was unused in favor of the `private_key_pass` param introduced in `SFTPHook`.
+
+For consistency, `private_key_pass` has been dropped in `SFTPHook` and `private_key_passphrase` is well reused.
+This way, a single connection can be used for both SSH and SFTP operations.
+

Review comment:
       I don't think this is the place for this.
   It's information about the backward incompatibility of a provider. 
   If I upgrade a provider I need to see this in the provider release notes not in Airflow release notes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org